Skip to content

amalgamated header json.h is broken #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mchalupa opened this issue Mar 21, 2016 · 1 comment
Closed

amalgamated header json.h is broken #448

mchalupa opened this issue Mar 21, 2016 · 1 comment
Assignees
@cdunn2001
Labels
bug

Comments

@mchalupa
Copy link

Hi,

the last merge broke the amalgamated sources, namely this line: ae56465#diff-3c93282e96d1ef08ede694c0f5ea8108R122

The json.h file now contains inlined version.h file (which is fine) and then there's an extra #include "version.h" (which breaks compilation if these files are used out of the tree)
@cdunn2001 cdunn2001 self-assigned this Mar 22, 2016
@cdunn2001 cdunn2001 added the bug label Mar 22, 2016
@cdunn2001
Copy link
Contributor

Please re-open if that doesn't fix it. Thanks for bringing it to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdunn2001 cdunn2001

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdunn2001 @mchalupa