From 1b9c4f440c3879b3147037179cc06d60885cc93a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Fri, 8 Aug 2025 10:41:01 +0200 Subject: [PATCH] improve: remove misleading log message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This warn message is logged even if missing config is expected Signed-off-by: Attila Mészáros --- .../api/config/AbstractConfigurationService.java | 13 ------------- .../api/config/BaseConfigurationService.java | 8 -------- 2 files changed, 21 deletions(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java index 5abe6a7d03..bddd4b0401 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java @@ -113,22 +113,9 @@ public ControllerConfiguration getConfigurationFor( Reconciler reconciler) { final var key = keyFor(reconciler); final var configuration = configurations.get(key); - if (configuration == null) { - logMissingReconcilerWarning(key, getReconcilersNameMessage()); - } return configuration; } - protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) { - log.warn("Cannot find reconciler named '{}'. {}", reconcilerKey, reconcilersNameMessage); - } - - private String getReconcilersNameMessage() { - return "Known reconcilers: " - + getKnownReconcilerNames().stream().reduce((s, s2) -> s + ", " + s2).orElse("None") - + "."; - } - protected String keyFor(Reconciler reconciler) { return ReconcilerUtils.getNameFor(reconciler); } diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java index 438f7d91a9..47c092358e 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java @@ -147,14 +147,6 @@ private static void configureFromAnnotatedReconciler( } } - @Override - protected void logMissingReconcilerWarning(String reconcilerKey, String reconcilersNameMessage) { - logger.warn( - "Configuration for reconciler '{}' was not found. {}", - reconcilerKey, - reconcilersNameMessage); - } - @SuppressWarnings("unused") public String getLoggerName() { return LOGGER_NAME;