Skip to content

🌱 Move catalogd controllers and webhooks to internal/catalogd #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

🌱 Move catalogd controllers and webhooks to internal/catalogd #1749

merged 2 commits into from
Feb 13, 2025

Conversation

LalatenduMohanty
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner February 12, 2025 04:47
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3a07791
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67ad289ba0bf6700087c4f11
😎 Deploy Preview https://deploy-preview-1749--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LalatenduMohanty LalatenduMohanty force-pushed the move_catalogd_controllers_webhooks branch from c43707e to 2af8b64 Compare February 12, 2025 04:49
@LalatenduMohanty LalatenduMohanty changed the title 🌱 [WIP] Move catalogd controllers and webhooks to internal/catalogd 🌱 Move catalogd controllers and webhooks to internal/catalogd Feb 12, 2025
@LalatenduMohanty LalatenduMohanty changed the title 🌱 Move catalogd controllers and webhooks to internal/catalogd 🌱 [WIP] Move catalogd controllers and webhooks to internal/catalogd Feb 12, 2025
joelanford
joelanford reviewed Feb 12, 2025
View reviewed changes
joelanford
joelanford reviewed Feb 12, 2025
View reviewed changes
joelanford
joelanford reviewed Feb 12, 2025
View reviewed changes
@LalatenduMohanty LalatenduMohanty force-pushed the move_catalogd_controllers_webhooks branch from 2af8b64 to f3b166c Compare February 12, 2025 15:59
@LalatenduMohanty
Moving catalogd controllers and webhook
d06df7f 
Moving  catalogd/internal/controllers and catalogd/internal/webhooks
to internal/catalogd along with the Makefile changes

Signed-off-by: Lalatendu Mohanty <[email protected]>
@LalatenduMohanty LalatenduMohanty force-pushed the move_catalogd_controllers_webhooks branch from f3b166c to d06df7f Compare February 12, 2025 22:35
@LalatenduMohanty
Removed 'build-deps' target from catalogd Makefile
3a07791 
As build-deps needs the generate target which has been moved to the root
Makefile i.e. operator-controller/Makefile

Signed-off-by: Lalatendu Mohanty <[email protected]>
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Feb 12, 2025 •
edited
Loading

I had to remove the build-deps target from the catalogd Makefile as well because it had dependancy on the manifest generation target. Next I would move the build target of catalogd Makefile. Refer 3a07791

@LalatenduMohanty LalatenduMohanty changed the title 🌱 [WIP] Move catalogd controllers and webhooks to internal/catalogd 🌱 Move catalogd controllers and webhooks to internal/catalogd Feb 12, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (becde51) to head (3a07791).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1749   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files          61       61           
  Lines        5245     5245           
=======================================
  Hits         3538     3538           
  Misses       1446     1446           
  Partials      261      261
Flag Coverage Δ
e2e 52.15% <ø> (ø)
unit 55.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

camilamacedo86
camilamacedo86 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@LalatenduMohanty
Copy link
Member Author

@joelanford PTAL

joelanford
joelanford reviewed Feb 13, 2025
View reviewed changes
catalogd/Makefile

.PHONY: build go-build-local $(BINARIES)
build: build-deps go-build-local ## Build binaries for current GOOS and GOARCH.
build: go-build-local ## Build binaries for current GOOS and GOARCH.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit unfortunate, as it requires that the root Makefile has already run it's generate target. But since this is just temporary, and we don't have any CI or dev flows where we would be running make tasks directly in the catalogd Makefile, I think its fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. We should move rest of the Makefile soon and that would remove the gap.

@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Feb 13, 2025
Merged via the queue into operator-framework:main with commit 43dfc65 Feb 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelanford joelanford joelanford left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Assignees

@camilamacedo86 camilamacedo86

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LalatenduMohanty @joelanford @camilamacedo86