Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: optimizely/optimizely-flutter-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: optimizely/optimizely-flutter-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: muzahid/custom-looger
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 17 files changed
  • 2 contributors

Commits on Sep 19, 2025

  1. build: add Optimizely SDK logger classes

    - Add FlutterOptimizelyLogger class implementing OPTLogger protocol
    - Add constants for customLogger and loggerChannel
    - Implement FlutterMethodChannel for invoking log method
    - Add logger field to OptimizelyFlutterSdk constructor
    - Initialize custom logger in OptimizelyClientWrapper
    - Create LoggerBridge to handle log method calls
    - Implement OptimizelyLogger interface and DefaultOptimizelyLogger class
    muzahidul-opti committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    be95ef5 View commit details
    Browse the repository at this point in the history
  2. fix: resolve logging inconsistencies

    - Update custom logger initialization in OptimizelyFlutterSdkPlugin
    - Adjust logger channel setup in onDetachedFromEngine
    - Refactor LoggerBridge to handle log calls from native Swift/Java code properly
    - Ensure proper logging when no custom logger is set
    muzahidul-opti committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    9b4c6fe View commit details
    Browse the repository at this point in the history
  3. refactor: update logger imports

    - Rename 'OptimizelyLogger.dart' to 'flutter_logger.dart'
    - Rename 'LoggerBridge.dart' to 'logger_bridge.dart'
    - Modify imports in 'optimizely_client_wrapper.dart' to reflect changes in logger files
    muzahidul-opti committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    2f88840 View commit details
    Browse the repository at this point in the history
  4. feat: add custom logger implementation

    - Implement a custom logger class
    - Define logLevel property with default debug level
    - Define log method to print log messages with custom format
    muzahidul-opti committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    6336b0c View commit details
    Browse the repository at this point in the history
  5. refactor: rename logger classes in Android and iOS

    - Rename FlutterOptimizelyLogger to OptimizelyFlutterLogger in Android
    - Rename FlutterOptimizelyLogger to OptimizelyFlutterLogger in iOS
    muzahidul-opti committed Sep 19, 2025
    Configuration menu
    Copy the full SHA
    40cfdaa View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2025

  1. feat: update logging behavior for Optimizely SDK

    - Remove unused log level property in CustomLogger
    - Implement channel setter method in OptimizelyFlutterLogger
    - Add guard clauses for levels and logger channel availability in log method
    - Update channel invocation to happen on main thread
    - Set log level in SwiftOptimizelyFlutterSdkPlugin based on parameters
    - Simplify DefaultOptimizelyLogger log method
    - Update log message formatting in logger bridge for consistency
    muzahidul-opti committed Sep 23, 2025
    Configuration menu
    Copy the full SHA
    8b401ca View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2025

  1. feat: add methods and tests for logger state management

    - Add methods to expose converting log level, checking if a custom logger is set, retrieving the current logger, and resetting the logger state
    - Implement a method for simulating method calls
    - Add tests for maintaining logger state across multiple operations
    - Include a test for handling logger replacement
    - Create tests for edge cases including handling empty messages and special characters
    muzahidul-opti committed Sep 24, 2025
    Configuration menu
    Copy the full SHA
    bde2659 View commit details
    Browse the repository at this point in the history
  2. feat: add separate logger channel for outgoing log calls

    - Define LOGGER_CHANNEL constant for OptimizelyFlutterLogger class
    - Set up separate FlutterMethodChannel for outgoing log calls
    - Update SwiftOptimizelyFlutterSdkPlugin to use the new logger channel
    muzahidul-opti committed Sep 24, 2025
    Configuration menu
    Copy the full SHA
    6993bfc View commit details
    Browse the repository at this point in the history
  3. refactor: improve main thread dispatch for Flutter method channel calls

    - Add DispatchQueue.main.async for each method call to ensure platform channel messages are sent on the correct thread
    muzahidul-opti committed Sep 24, 2025
    Configuration menu
    Copy the full SHA
    9b26c39 View commit details
    Browse the repository at this point in the history
  4. chore: clean up logger implementation

    - Remove unnecessary comments and TODOs
    - Replace direct print statements with AppLogger methods
    - Refactor AppLogger to enhance flexibility and ease of use
    muzahidul-opti committed Sep 24, 2025
    Configuration menu
    Copy the full SHA
    a0a9ca9 View commit details
    Browse the repository at this point in the history
  5. style: update comment in sendLogToFlutter method

    - Remove comparison to Swift's DispatchQueue.main.async
    muzahidul-opti committed Sep 24, 2025
    Configuration menu
    Copy the full SHA
    8edc431 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2025

  1. chore: remove unused import statement

    - Remove import statement for 'log_level' that is no longer used
    - Update import paths for 'flutter_logger' and 'optimizely_flutter_sdk'
    
    test: update test cases in logger_test.dart
    
    - Update test cases to use 'const MethodCall' for creating method calls
    - Change null and empty arguments to be created and handled correctly
    - Fix missing level or message argument handling scenarios
    - Improve handling of invalid level data types in method calls
    
    docs: add comments to improve code clarity in logger_test.dart
    
    - Add comments explaining the purpose of each test group and case
    - Include comments for the different scenarios being tested in each case
    muzahidul-opti committed Sep 25, 2025
    Configuration menu
    Copy the full SHA
    49ed2dc View commit details
    Browse the repository at this point in the history
  2. chore: update log messages and method channel handling

    - Update log message format in CustomLogger class
    - Refactor main thread dispatch logic for method channel calls in Utils.swift
    - Enhance error handling and main thread dispatch in OptimizelyFlutterLogger.swift
    - Modify method channel creation and task queue handling in SwiftOptimizelyFlutterSdkPlugin.swift
    muzahidul-opti committed Sep 25, 2025
    Configuration menu
    Copy the full SHA
    7ae86de View commit details
    Browse the repository at this point in the history
  3. refactor: enhance logging functionalities

    - Replace usage of static AppLogger class with separate logging functions
    - Introduce individual logger functions for error, warning, info, and debug levels
    - Create a default stand-alone logger instance to handle logging operations
    muzahidul-opti committed Sep 25, 2025
    Configuration menu
    Copy the full SHA
    e6404aa View commit details
    Browse the repository at this point in the history
  4. test: add global logging functions test cases

    - Test calling global logging functions without errors
    - Test handling empty messages in global functions
    - Test handling special characters in global functions
    - Test handling rapid calls to global functions
    muzahidul-opti committed Sep 25, 2025
    Configuration menu
    Copy the full SHA
    c2f1507 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2025

  1. Configuration menu
    Copy the full SHA
    4b54235 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2025

  1. chore: update Android configuration and logging setup

    - Add Kotlin support to build.gradle
    - Update Java version compatibility
    - Include Kotlin options for JVM target
    - Implement FlutterLogbackAppender for logging
    - Remove unused OptimizelyFlutterLogger class
    - Refactor logger initialization in OptimizelyFlutterSdkPlugin
    - Update MethodChannel for log messages in LoggerBridge
    muzahidul-opti committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    83a4cc3 View commit details
    Browse the repository at this point in the history
  2. chore: update android build.gradle

    - Remove unused 'org.jetbrains.kotlin.android' plugin
    - Remove 'kotlinOptions' block for JVM target compatibility update
    - Add exclusion for 'androidsupportmultidexversion.txt' in packagingOptions
    
    feat: add FlutterLogbackAppender for logging in Android
    
    - Add new FlutterLogbackAppender class for logging
    - Implement append method to handle log events
    - Include mainThreadHandler for posting log data asynchronously
    - Provide setChannel method for setting MethodChannel in FlutterLogbackAppender
    
    refactor: simplify channel set in OptimizelyFlutterSdkPlugin.java
    
    - Update channel set method to use static reference directly
    muzahidul-opti committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    ed10620 View commit details
    Browse the repository at this point in the history
  3. refactor: remove logging statements

    - Remove logging statement for receiving method call
    - Remove logging statement for processing log
    muzahidul-opti committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    55bfb25 View commit details
    Browse the repository at this point in the history
Loading