Skip to content

[FSSDK-9375]: Makes SendOdpEvent for iOS consistent with android. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2023
Merged

[FSSDK-9375]: Makes SendOdpEvent for iOS consistent with android. #59

merged 2 commits into from
May 18, 2023

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented May 18, 2023 •
edited
Loading

Summary

  • Instead of returning error for sendOdpEvent for iOS, error is printed and success is returned as true

Test plan

  • All previous unit tests should pass.

Issues

mikechu-optimizely
mikechu-optimizely previously approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mnoman09
mnoman09 previously approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@mnoman09 mnoman09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yasirfolio3 yasirfolio3 dismissed stale reviews from mnoman09 and mikechu-optimizely via 9f57f79 May 18, 2023 17:07
@yasirfolio3 yasirfolio3 reopened this May 18, 2023
@yasirfolio3 yasirfolio3 merged commit 9471ff0 into master May 18, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-9375 branch May 18, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001 Mat001 Awaiting requested review from Mat001

@mnoman09 mnoman09 Awaiting requested review from mnoman09

@mikechu-optimizely mikechu-optimizely Awaiting requested review from mikechu-optimizely

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yasirfolio3 @mnoman09 @mikechu-optimizely