Got response "We received a malformed request from your client" when try to upload image with github api

[M-Kepler]

Select Topic Area

Question

Body

When I try to upload an image file via the https://docs.github.com/zh/rest/repos/contents?apiVersion=2022-11-28#create-or-update-file-contents interface, I get an error:

We received a malformed request from your client. Sorry about that. Please try resubmitting your request and contact us if the problem persists.: 400 {"message": "We received a malformed request from your client. Sorry about that. Please try resubmitting your request and contact us if the problem persists."}

But upload a normal text file is OK.

Is GitHub API not allowed to upload files?

---

Here's my code:

import requests
import base64
import json
import uuid
import datetime
import os
ext = ""


def read_dir():
    global ext
    path = "D:/GiteeProjects/uploadPicture/upload"
	
    files = os.listdir(path
    for file in files: 
        if not os.path.isdir(file): 
            ext = os.path.splitext(file)[1]
            with open(path + "/" + file, 'rb') as f:
                fdata_tmp = file_base64(f.read())
                f.close()
                return fdata_tmp 
				

def file_base64(data):
    data_b64 = base64.b64encode(data).decode()
    return data_b64
	

def upload_file(file_data):
    global ext
    file_name = str(uuid.uuid1()) + ext
    # token = "[token]" todo
    # url = "https://api.github.com/repos/[user]/[repo]/contents/[path]/"+file_name
    # headers = {"Authorization": "token " + token}
    token = "ghp_rOTMBxxxxxxxxxxxxxxxxxgu4dSvzi"
    curr_time = datetime.datetime.now()
    path = curr_time.strftime("%Y-%m-%d")
    url = "https://api.github.com/repos/xxxx/MyxxxxBed/contents/" + path + "/" + file_name
    headers = {"Authorization": "token " + token}
    content = file_data
    data = {
        "message": "zj upload pictures",
        "content": content
    }
    data = json.dumps(data)
    req = requests.put(url=url, data=data, headers=headers)
    req.encoding = "utf-8"
    re_data = json.loads(req.text)
    print("https://cdn.jsdelivr.net/gh/[user]/[repo]/[path]" + file_name)


if __name__ == '__main__':
    fdata = read_dir()
    
    upload_file(fdata)

[M-Kepler]

I think the endpoint will be ok, becouse some app like https://github.com/XPoet/picx (upload image to github) is still working.

[M-Kepler]

Find that only image size < 40k can be upload by API!!!, is there other way to upload larger thar 40k?

[SuvasishChowdhury]

The Problem: Missing Content-Type Header
Your current upload_file function sets the Authorization header but omits the necessary Content-Type header:

The Solution: Add the Content-Type Header
You need to tell the GitHub API that the data you are sending is a JSON string.

Secondary Check: File Size
As a secondary step, if the above change does not fix the issue, your image file may be exceeding the API's limit.

The GitHub API accepts files up to 100 MB, but since the file contents must be Base64-encoded, the actual size of your image file should be kept below ≈75 MB (as Base64 adds about 33% overhead).

Thank you.
(Mark this answer if you find this helpful for your case).