Test enhancement

Author: peter279k

.travis.yml

@@ -1,18 +1,17 @@
 language: php
 
 php:
-  - '7.0.17'
   - '7.0'
-  - '7.1.2'
+  - '7.1'
+  - '7.2'
   - nightly
 
 before_script:
 # In case of timeouts and build failures you may want to prepend 'travis_retry' to the following commands:
-  - curl -s http://getcomposer.org/installer | php
-  - php composer.phar install -n
+  - composer install -n
 
 # Explicitly use the phpunit from composer, not any system-wide found
-script: 
+script:
   - php vendor/bin/phpunit --coverage-clover build/coverage/xml tests
 
 after_success:

tests/Codacy/Coverage/Parser/CloverParserTest.php

@@ -8,6 +8,7 @@ class CloverParserTest extends \PHPUnit\Framework\TestCase
     public function testThrowsExceptionOnWrongPath()
     {
         $this->expectException('InvalidArgumentException');
+        $this->expectExceptionMessage('Unable to load the xml file. Make sure path is properly set. Using: "/home/foo/bar/baz/m.xml"');
         new CloverParser("/home/foo/bar/baz/m.xml");
     }
 

tests/Codacy/Coverage/Parser/ParserTest.php

@@ -31,4 +31,14 @@ public function testParsersProduceSameResult()
 
         $this->assertJsonStringEqualsJsonString($expectedJson, $xunitJson);
     }
+
+    public function testConstructorOnNullRootDir()
+    {
+        $parser = new PhpUnitXmlParser('tests/res/phpunitxml/index.xml');
+        $parser->setDirOfFileXmls("tests/res/phpunitxml");
+        $report = $parser->makeReport();
+
+        $this->assertEquals(69, $report->getTotal());
+        $this->assertEquals(10, sizeof($report->getFileReports()));
+    }
 }

tests/Codacy/Coverage/Parser/PhpUnitXmlParserTest.php

@@ -12,6 +12,14 @@ public function testThrowsExceptionOnWrongPath()
         new PhpUnitXmlParser("/home/foo/bar/baz/fake.xml");
     }
 
+    public function testMakeReportThrowsExceptionOnWrndPath()
+    {
+        $parser = new PhpUnitXmlParser('tests/res/phpunitxml/index.xml', '/home/jacke/Desktop/codacy-php');
+
+        $this->expectException('InvalidArgumentException');
+        $parser->makeReport();
+    }
+
     /**
      * Testing against the clover coverage report 'tests/res/clover/clover.xml'
      * The test had been made in /home/jacke/Desktop/codacy-php so we need to pass this