Symfony async events. Add tests for async processor.

Author: makasim

pkg/enqueue-bundle/Events/ProxyEventDispatcher.php

@@ -2,11 +2,12 @@
 
 namespace Enqueue\Bundle\Events;
 
+use Symfony\Component\DependencyInjection\ContainerInterface;
+use Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher;
 use Symfony\Component\EventDispatcher\Event;
-use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
-class ProxyEventDispatcher extends EventDispatcher
+class ProxyEventDispatcher extends ContainerAwareEventDispatcher
 {
     /**
      * @var EventDispatcherInterface
@@ -19,11 +20,14 @@ class ProxyEventDispatcher extends EventDispatcher
     private $asyncListener;
 
     /**
+     * @param ContainerInterface       $container
      * @param EventDispatcherInterface $trueEventDispatcher
      * @param AsyncListener            $asyncListener
      */
-    public function __construct(EventDispatcherInterface $trueEventDispatcher, AsyncListener $asyncListener)
+    public function __construct(ContainerInterface $container, EventDispatcherInterface $trueEventDispatcher, AsyncListener $asyncListener)
     {
+        parent::__construct($container);
+
         $this->trueEventDispatcher = $trueEventDispatcher;
         $this->asyncListener = $asyncListener;
     }

pkg/enqueue-bundle/Resources/config/events.yml

@@ -14,6 +14,7 @@ services:
     enqueue.events.event_dispatcher:
         class: 'Enqueue\Bundle\Events\ProxyEventDispatcher'
         arguments:
+            - '@service_container'
             - '@event_dispatcher'
             - '@enqueue.events.async_listener'
 

pkg/enqueue-bundle/Tests/Functional/Events/AsyncListenerTest.php

@@ -10,6 +10,9 @@
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\EventDispatcher\GenericEvent;
 
+/**
+ * @group functional
+ */
 class AsyncListenerTest extends WebTestCase
 {
     public function setUp()
@@ -29,10 +32,10 @@ public function testShouldNotCallRealListenerIfMarkedAsAsync()
 
         $dispatcher->dispatch('test_async', new GenericEvent('aSubject'));
 
-        /** @var TestAsyncListener $listner */
-        $listner = $this->container->get('test_async_listener');
+        /** @var TestAsyncListener $listener */
+        $listener = $this->container->get('test_async_listener');
 
-        $this->assertEmpty($listner->calls);
+        $this->assertEmpty($listener->calls);
     }
 
     public function testShouldSendMessageToExpectedTopicInsteadOfCallingRealListener()

pkg/enqueue-bundle/Tests/Functional/Events/AsyncProcessorTest.php

@@ -0,0 +1,85 @@
+<?php
+
+namespace Enqueue\Bundle\Tests\Functional\Events;
+
+use Enqueue\Bundle\Events\AsyncListener;
+use Enqueue\Bundle\Events\AsyncProcessor;
+use Enqueue\Bundle\Tests\Functional\App\TestAsyncListener;
+use Enqueue\Bundle\Tests\Functional\WebTestCase;
+use Enqueue\Null\NullContext;
+use Enqueue\Null\NullMessage;
+use Enqueue\Psr\PsrProcessor;
+use Symfony\Component\EventDispatcher\GenericEvent;
+
+/**
+ * @group functional
+ */
+class AsyncProcessorTest extends WebTestCase
+{
+    public function setUp()
+    {
+        parent::setUp();
+
+        /** @var AsyncListener $asyncListener */
+        $asyncListener = $this->container->get('enqueue.events.async_listener');
+
+        $asyncListener->resetSyncMode();
+    }
+
+    public function testCouldBeGetFromContainerAsService()
+    {
+        /** @var AsyncProcessor $processor */
+        $processor = $this->container->get('enqueue.events.async_processor');
+
+        $this->assertInstanceOf(AsyncProcessor::class, $processor);
+    }
+
+    public function testShouldRejectIfMessageDoesNotContainEventNameProperty()
+    {
+        /** @var AsyncProcessor $processor */
+        $processor = $this->container->get('enqueue.events.async_processor');
+
+        $message = new NullMessage();
+
+        $this->assertEquals(PsrProcessor::REJECT, $processor->process($message, new NullContext()));
+    }
+
+    public function testShouldRejectIfMessageDoesNotContainTransformerNameProperty()
+    {
+        /** @var AsyncProcessor $processor */
+        $processor = $this->container->get('enqueue.events.async_processor');
+
+        $message = new NullMessage();
+        $message->setProperty('event_name', 'anEventName');
+
+        $this->assertEquals(PsrProcessor::REJECT, $processor->process($message, new NullContext()));
+    }
+
+    public function testShouldCallRealListener()
+    {
+        /** @var AsyncProcessor $processor */
+        $processor = $this->container->get('enqueue.events.async_processor');
+
+        $event = new GenericEvent('theSubject', ['fooArg' => 'fooVal']);
+
+        $message = new NullMessage();
+        $message->setProperty('event_name', 'test_async');
+        $message->setProperty('transformer_name', 'php_serializer');
+        $message->setBody(serialize($event));
+
+        $this->assertEquals(PsrProcessor::ACK, $processor->process($message, new NullContext()));
+
+        /** @var TestAsyncListener $listener */
+        $listener = $this->container->get('test_async_listener');
+
+        $this->assertNotEmpty($listener->calls);
+
+        $this->assertEquals($event, $listener->calls[0][0]);
+        $this->assertEquals('test_async', $listener->calls[0][1]);
+
+        $this->assertSame(
+            $this->container->get('enqueue.events.event_dispatcher'),
+            $listener->calls[0][2]
+        );
+    }
+}