Skip to content

Commit b498fab

Browse files
committed
Internal param name consistency with api
1 parent 1d86654 commit b498fab

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

ext/reflection/php_reflection.c

+6-7
Original file line numberDiff line numberDiff line change
@@ -5188,7 +5188,7 @@ void reflection_class_new_lazy(INTERNAL_FUNCTION_PARAMETERS,
51885188
zend_class_entry *ce;
51895189
zend_fcall_info fci;
51905190
zend_fcall_info_cache fcc;
5191-
zend_long flags = 0;
5191+
zend_long options = 0;
51925192

51935193
ZEND_ASSERT(strategy == ZEND_LAZY_OBJECT_STRATEGY_GHOST
51945194
|| strategy == ZEND_LAZY_OBJECT_STRATEGY_PROXY);
@@ -5200,20 +5200,19 @@ void reflection_class_new_lazy(INTERNAL_FUNCTION_PARAMETERS,
52005200
Z_PARAM_OBJ_OF_CLASS(obj, ce)
52015201
Z_PARAM_FUNC(fci, fcc)
52025202
Z_PARAM_OPTIONAL
5203-
// TODO: check named param
5204-
Z_PARAM_LONG(flags)
5203+
Z_PARAM_LONG(options)
52055204
ZEND_PARSE_PARAMETERS_END();
52065205
} else {
52075206
ZEND_PARSE_PARAMETERS_START(1, 2)
52085207
Z_PARAM_FUNC(fci, fcc)
52095208
Z_PARAM_OPTIONAL
5210-
Z_PARAM_LONG(flags)
5209+
Z_PARAM_LONG(options)
52115210
ZEND_PARSE_PARAMETERS_END();
52125211
obj = NULL;
52135212
}
52145213

5215-
if (flags & ~ZEND_LAZY_OBJECT_USER_FLAGS) {
5216-
zend_throw_exception_ex(reflection_exception_ptr, 0, "Invalid flags");
5214+
if (options & ~ZEND_LAZY_OBJECT_USER_FLAGS) {
5215+
zend_throw_exception_ex(reflection_exception_ptr, 0, "Invalid options");
52175216
RETURN_THROWS();
52185217
}
52195218

@@ -5234,7 +5233,7 @@ void reflection_class_new_lazy(INTERNAL_FUNCTION_PARAMETERS,
52345233
}
52355234

52365235
obj = zend_object_make_lazy(obj, ce, &fci.function_name, &fcc,
5237-
strategy | flags);
5236+
strategy | options);
52385237

52395238
if (!obj) {
52405239
RETURN_THROWS();

0 commit comments

Comments
 (0)