Skip to content

Require poll() for UNIX based OSs and improve emulation for Windows #15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Girgias opened this issue Aug 21, 2024 · 2 comments
Open

Require poll() for UNIX based OSs and improve emulation for Windows #15532

Girgias opened this issue Aug 21, 2024 · 2 comments

Comments

@Girgias
Copy link
Member

Girgias commented Aug 21, 2024

Description

This would allow some simplification of the php_network.h header and of our emulation layer.

Initially found while working on #15511

@cmb69
Copy link
Member

cmb69 commented Aug 22, 2024

Makes sense to do this, but unless we are absolutely sure that all non Windows we are supporting support poll(), maybe it's better to postpone that to PHP next (8.5 or 9.0).

@Girgias
Copy link
Member Author

Girgias commented Aug 22, 2024

This is definitely not urgent, the point of the issue is to have a reminder somewhere of this!

I also think it is better to wait for the next release as we're already in beta, and I am a bit vary to change such an aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants