Skip to content

make black formatting consistent on desktop and in CI #5204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvwilson opened this issue May 27, 2025 · 0 comments
Open

make black formatting consistent on desktop and in CI #5204

gvwilson opened this issue May 27, 2025 · 0 comments
Assignees
Labels
bug something broken infrastructure build process etc. P1 needed for current cycle

Comments

@gvwilson
Copy link
Contributor

We discovered while working on #5199 that black behaves differently when run during codegen than when run directly on the command line (as it is in CI). We suspect this may be because codegen runs black separately for three sub-directories, while black --check . --exclude .venv (as used in CI) runs it from the root directory. These need to be reconciled.

@gvwilson gvwilson self-assigned this May 27, 2025
@gvwilson gvwilson added bug something broken P1 needed for current cycle infrastructure build process etc. labels May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken infrastructure build process etc. P1 needed for current cycle
Projects
None yet
Development

No branches or pull requests

1 participant