Skip to content

Commit 0600c8c

Browse files
reshkeCommitfest Bot
reshke
authored and
Commitfest Bot
committed
Remove unneeded cast in BufferGetPage
1 parent 80f1106 commit 0600c8c

File tree

22 files changed

+69
-69
lines changed

22 files changed

+69
-69
lines changed

‎contrib/amcheck/verify_gin.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ gin_check_posting_tree_parent_keys_consistency(Relation rel, BlockNumber posting
174174
buffer = ReadBufferExtended(rel, MAIN_FORKNUM, stack->blkno,
175175
RBM_NORMAL, strategy);
176176
LockBuffer(buffer, GIN_SHARE);
177-
page = (Page) BufferGetPage(buffer);
177+
page = BufferGetPage(buffer);
178178

179179
Assert(GinPageIsData(page));
180180

@@ -434,7 +434,7 @@ gin_check_parent_keys_consistency(Relation rel,
434434
buffer = ReadBufferExtended(rel, MAIN_FORKNUM, stack->blkno,
435435
RBM_NORMAL, strategy);
436436
LockBuffer(buffer, GIN_SHARE);
437-
page = (Page) BufferGetPage(buffer);
437+
page = BufferGetPage(buffer);
438438
maxoff = PageGetMaxOffsetNumber(page);
439439
rightlink = GinPageGetOpaque(page)->rightlink;
440440

‎contrib/bloom/blvacuum.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ blvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
192192
buffer = ReadBufferExtended(index, MAIN_FORKNUM, blkno,
193193
RBM_NORMAL, info->strategy);
194194
LockBuffer(buffer, BUFFER_LOCK_SHARE);
195-
page = (Page) BufferGetPage(buffer);
195+
page = BufferGetPage(buffer);
196196

197197
if (PageIsNew(page) || BloomPageIsDeleted(page))
198198
{

‎contrib/pgstattuple/pgstatindex.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ pgstathashindex(PG_FUNCTION_ARGS)
647647
buf = ReadBufferExtended(rel, MAIN_FORKNUM, blkno, RBM_NORMAL,
648648
bstrategy);
649649
LockBuffer(buf, BUFFER_LOCK_SHARE);
650-
page = (Page) BufferGetPage(buf);
650+
page = BufferGetPage(buf);
651651

652652
if (PageIsNew(page))
653653
stats.unused_pages++;

‎contrib/pgstattuple/pgstattuple.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)
378378
buffer = ReadBufferExtended(rel, MAIN_FORKNUM, block,
379379
RBM_NORMAL, hscan->rs_strategy);
380380
LockBuffer(buffer, BUFFER_LOCK_SHARE);
381-
stat.free_space += PageGetExactFreeSpace((Page) BufferGetPage(buffer));
381+
stat.free_space += PageGetExactFreeSpace(BufferGetPage(buffer));
382382
UnlockReleaseBuffer(buffer);
383383
block++;
384384
}
@@ -391,7 +391,7 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)
391391
buffer = ReadBufferExtended(rel, MAIN_FORKNUM, block,
392392
RBM_NORMAL, hscan->rs_strategy);
393393
LockBuffer(buffer, BUFFER_LOCK_SHARE);
394-
stat.free_space += PageGetExactFreeSpace((Page) BufferGetPage(buffer));
394+
stat.free_space += PageGetExactFreeSpace(BufferGetPage(buffer));
395395
UnlockReleaseBuffer(buffer);
396396
block++;
397397
}

‎src/backend/access/brin/brin_xlog.c‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ brin_xlog_createidx(XLogReaderState *record)
3131
/* create the index' metapage */
3232
buf = XLogInitBufferForRedo(record, 0);
3333
Assert(BufferIsValid(buf));
34-
page = (Page) BufferGetPage(buf);
34+
page = BufferGetPage(buf);
3535
brin_metapage_init(page, xlrec->pagesPerRange, xlrec->version);
3636
PageSetLSN(page, lsn);
3737
MarkBufferDirty(buf);
@@ -82,7 +82,7 @@ brin_xlog_insert_update(XLogReaderState *record,
8282

8383
Assert(tuple->bt_blkno == xlrec->heapBlk);
8484

85-
page = (Page) BufferGetPage(buffer);
85+
page = BufferGetPage(buffer);
8686
offnum = xlrec->offnum;
8787
if (PageGetMaxOffsetNumber(page) + 1 < offnum)
8888
elog(PANIC, "brin_xlog_insert_update: invalid max offset number");
@@ -104,7 +104,7 @@ brin_xlog_insert_update(XLogReaderState *record,
104104
ItemPointerData tid;
105105

106106
ItemPointerSet(&tid, regpgno, xlrec->offnum);
107-
page = (Page) BufferGetPage(buffer);
107+
page = BufferGetPage(buffer);
108108

109109
brinSetHeapBlockItemptr(buffer, xlrec->pagesPerRange, xlrec->heapBlk,
110110
tid);
@@ -146,7 +146,7 @@ brin_xlog_update(XLogReaderState *record)
146146
Page page;
147147
OffsetNumber offnum;
148148

149-
page = (Page) BufferGetPage(buffer);
149+
page = BufferGetPage(buffer);
150150

151151
offnum = xlrec->oldOffnum;
152152

@@ -185,7 +185,7 @@ brin_xlog_samepage_update(XLogReaderState *record)
185185

186186
brintuple = (BrinTuple *) XLogRecGetBlockData(record, 0, &tuplen);
187187

188-
page = (Page) BufferGetPage(buffer);
188+
page = BufferGetPage(buffer);
189189

190190
offnum = xlrec->offnum;
191191

@@ -254,7 +254,7 @@ brin_xlog_revmap_extend(XLogReaderState *record)
254254
*/
255255

256256
buf = XLogInitBufferForRedo(record, 1);
257-
page = (Page) BufferGetPage(buf);
257+
page = BufferGetPage(buf);
258258
brin_page_init(page, BRIN_PAGETYPE_REVMAP);
259259

260260
PageSetLSN(page, lsn);

‎src/backend/access/gin/ginvacuum.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
753753
buffer = ReadBufferExtended(index, MAIN_FORKNUM, blkno,
754754
RBM_NORMAL, info->strategy);
755755
LockBuffer(buffer, GIN_SHARE);
756-
page = (Page) BufferGetPage(buffer);
756+
page = BufferGetPage(buffer);
757757

758758
if (GinPageIsRecyclable(page))
759759
{

‎src/backend/access/gin/ginxlog.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ ginRedoClearIncompleteSplit(XLogReaderState *record, uint8 block_id)
3030

3131
if (XLogReadBufferForRedo(record, block_id, &buffer) == BLK_NEEDS_REDO)
3232
{
33-
page = (Page) BufferGetPage(buffer);
33+
page = BufferGetPage(buffer);
3434
GinPageGetOpaque(page)->flags &= ~GIN_INCOMPLETE_SPLIT;
3535

3636
PageSetLSN(page, lsn);
@@ -50,7 +50,7 @@ ginRedoCreatePTree(XLogReaderState *record)
5050
Page page;
5151

5252
buffer = XLogInitBufferForRedo(record, 0);
53-
page = (Page) BufferGetPage(buffer);
53+
page = BufferGetPage(buffer);
5454

5555
GinInitBuffer(buffer, GIN_DATA | GIN_LEAF | GIN_COMPRESSED);
5656

‎src/backend/access/gist/gist.c‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -696,7 +696,7 @@ gistdoinsert(Relation r, IndexTuple itup, Size freespace,
696696
gistcheckpage(state.r, stack->buffer);
697697
}
698698

699-
stack->page = (Page) BufferGetPage(stack->buffer);
699+
stack->page = BufferGetPage(stack->buffer);
700700
stack->lsn = xlocked ?
701701
PageGetLSN(stack->page) : BufferGetLSNAtomic(stack->buffer);
702702
Assert(!RelationNeedsWAL(state.r) || !XLogRecPtrIsInvalid(stack->lsn));
@@ -783,7 +783,7 @@ gistdoinsert(Relation r, IndexTuple itup, Size freespace,
783783
LockBuffer(stack->buffer, GIST_UNLOCK);
784784
LockBuffer(stack->buffer, GIST_EXCLUSIVE);
785785
xlocked = true;
786-
stack->page = (Page) BufferGetPage(stack->buffer);
786+
stack->page = BufferGetPage(stack->buffer);
787787

788788
if (PageGetLSN(stack->page) != stack->lsn)
789789
{
@@ -847,7 +847,7 @@ gistdoinsert(Relation r, IndexTuple itup, Size freespace,
847847
LockBuffer(stack->buffer, GIST_UNLOCK);
848848
LockBuffer(stack->buffer, GIST_EXCLUSIVE);
849849
xlocked = true;
850-
stack->page = (Page) BufferGetPage(stack->buffer);
850+
stack->page = BufferGetPage(stack->buffer);
851851
stack->lsn = PageGetLSN(stack->page);
852852

853853
if (stack->blkno == GIST_ROOT_BLKNO)
@@ -938,7 +938,7 @@ gistFindPath(Relation r, BlockNumber child, OffsetNumber *downlinkoffnum)
938938
buffer = ReadBuffer(r, top->blkno);
939939
LockBuffer(buffer, GIST_SHARE);
940940
gistcheckpage(r, buffer);
941-
page = (Page) BufferGetPage(buffer);
941+
page = BufferGetPage(buffer);
942942

943943
if (GistPageIsLeaf(page))
944944
{
@@ -1033,7 +1033,7 @@ gistFindCorrectParent(Relation r, GISTInsertStack *child, bool is_build)
10331033
GISTInsertStack *ptr;
10341034

10351035
gistcheckpage(r, parent->buffer);
1036-
parent->page = (Page) BufferGetPage(parent->buffer);
1036+
parent->page = BufferGetPage(parent->buffer);
10371037
maxoff = PageGetMaxOffsetNumber(parent->page);
10381038

10391039
/* Check if the downlink is still where it was before */
@@ -1098,7 +1098,7 @@ gistFindCorrectParent(Relation r, GISTInsertStack *child, bool is_build)
10981098
parent->buffer = ReadBuffer(r, parent->blkno);
10991099
LockBuffer(parent->buffer, GIST_EXCLUSIVE);
11001100
gistcheckpage(r, parent->buffer);
1101-
parent->page = (Page) BufferGetPage(parent->buffer);
1101+
parent->page = BufferGetPage(parent->buffer);
11021102
}
11031103

11041104
/*
@@ -1121,7 +1121,7 @@ gistFindCorrectParent(Relation r, GISTInsertStack *child, bool is_build)
11211121
while (ptr)
11221122
{
11231123
ptr->buffer = ReadBuffer(r, ptr->blkno);
1124-
ptr->page = (Page) BufferGetPage(ptr->buffer);
1124+
ptr->page = BufferGetPage(ptr->buffer);
11251125
ptr = ptr->parent;
11261126
}
11271127

‎src/backend/access/gist/gistbuild.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -969,7 +969,7 @@ gistProcessItup(GISTBuildState *buildstate, IndexTuple itup,
969969
buffer = ReadBuffer(indexrel, blkno);
970970
LockBuffer(buffer, GIST_EXCLUSIVE);
971971

972-
page = (Page) BufferGetPage(buffer);
972+
page = BufferGetPage(buffer);
973973
childoffnum = gistchoose(indexrel, page, itup, giststate);
974974
iid = PageGetItemId(page, childoffnum);
975975
idxtuple = (IndexTuple) PageGetItem(page, iid);
@@ -1448,7 +1448,7 @@ gistGetMaxLevel(Relation index)
14481448
* pro forma.
14491449
*/
14501450
LockBuffer(buffer, GIST_SHARE);
1451-
page = (Page) BufferGetPage(buffer);
1451+
page = BufferGetPage(buffer);
14521452

14531453
if (GistPageIsLeaf(page))
14541454
{

‎src/backend/access/gist/gistvacuum.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ gistvacuumpage(GistVacState *vstate, Buffer buffer)
330330
* exclusive lock.
331331
*/
332332
LockBuffer(buffer, GIST_EXCLUSIVE);
333-
page = (Page) BufferGetPage(buffer);
333+
page = BufferGetPage(buffer);
334334

335335
if (gistPageRecyclable(page))
336336
{
@@ -528,7 +528,7 @@ gistvacuum_delete_empty_pages(IndexVacuumInfo *info, GistVacState *vstate)
528528
RBM_NORMAL, info->strategy);
529529

530530
LockBuffer(buffer, GIST_SHARE);
531-
page = (Page) BufferGetPage(buffer);
531+
page = BufferGetPage(buffer);
532532

533533
if (PageIsNew(page) || GistPageIsDeleted(page) || GistPageIsLeaf(page))
534534
{

0 commit comments

Comments
 (0)