remove duplicated smgrclose

Remove redundant `smgrclose` calls after `smgrdounlinkall`.
The `smgrdounlinkall` now handles all necessary cleanup,
making additional closes unnecessary.

Author: Steven Niu <[email protected]>
Reviewed-by: Junwang Zhao

Discussion: https://www.postgresql.org/message-id/flat/CABBtG=cDTCBDCBK7McSy6bJR3s5xUTOg0vSFfuW8oLdUYyCscA@mail.gmail.com

Author: Steven Niu

src/backend/catalog/storage.c

@@ -727,9 +727,6 @@ smgrDoPendingDeletes(bool isCommit)
 	{
 		smgrdounlinkall(srels, nrels, false);
 
-		for (int i = 0; i < nrels; i++)
-			smgrclose(srels[i]);
-
 		pfree(srels);
 	}
 }

src/backend/storage/smgr/md.c

@@ -1606,8 +1606,6 @@ DropRelationFiles(RelFileLocator *delrels, int ndelrels, bool isRedo)
 
 	smgrdounlinkall(srels, ndelrels, isRedo);
 
-	for (i = 0; i < ndelrels; i++)
-		smgrclose(srels[i]);
 	pfree(srels);
 }
 

src/backend/utils/cache/relcache.c

@@ -3802,7 +3802,6 @@ RelationSetNewRelfilenumber(Relation relation, char persistence)
 		 */
 		srel = smgropen(relation->rd_locator, relation->rd_backend);
 		smgrdounlinkall(&srel, 1, false);
-		smgrclose(srel);
 	}
 	else
 	{