Skip to content

Commit 2cc1bd8

Browse files
JelteFCommitfest Bot
authored andcommitted
Rename protocol extensions to protocol options in docs
Currently we call connection parameters that have the "_pq_." prefix both "protocol options" and "protocol extensions". This standardizes on calling them "protocol options". The primary reason to do this is so people don't associate them with Postgres extensions, with which they have nothing to do. They are completely separate things, and Postgres extensions currently cannot even define their own protocol options.
1 parent 03f8e9a commit 2cc1bd8

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

doc/src/sgml/protocol.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6066,7 +6066,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
60666066

60676067
In addition to the above, other parameters may be listed.
60686068
Parameter names beginning with <literal>_pq_.</literal> are
6069-
reserved for use as protocol extensions, while others are
6069+
reserved for use as protocol options, while others are
60706070
treated as run-time parameters to be set at backend start
60716071
time. Such settings will be applied during backend start
60726072
(after parsing the command-line arguments if any) and will

src/backend/backup/basebackup_copy.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
* the course of that single COPY OUT. Each CopyData message begins with a
1010
* type byte, allowing us to signal the start of a new archive, or the
1111
* manifest, by some means other than ending the COPY stream. This also allows
12-
* for future protocol extensions, since we can include arbitrary information
12+
* for future protocol options, since we can include arbitrary information
1313
* in the message stream as long as we're certain that the client will know
1414
* what to do with it.
1515
*

src/interfaces/libpq/fe-protocol3.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,8 +1439,8 @@ pqGetNegotiateProtocolVersion3(PGconn *conn)
14391439
if (num > 0)
14401440
{
14411441
appendPQExpBuffer(&conn->errorMessage,
1442-
libpq_ngettext("protocol extension not supported by server: %s",
1443-
"protocol extensions not supported by server: %s", num),
1442+
libpq_ngettext("protocol option not supported by server: %s",
1443+
"protocol options not supported by server: %s", num),
14441444
buf.data);
14451445
appendPQExpBufferChar(&conn->errorMessage, '\n');
14461446
}

0 commit comments

Comments
 (0)