Skip to content

Commit 310d041

Browse files
peterenmisch
andcommitted
Put back intra-grant-inplace.spec test coverage
Commit d31bbfb lost some test coverage, because the situation being tested, a concurrent DROP, cannot happen anymore. Put the test coverage back with a bit of a trick, by deleting directly from the catalog table. Co-authored-by: Noah Misch <[email protected]> Reviewed-by: Heikki Linnakangas <[email protected]> Discussion: https://www.postgresql.org/message-id/flat/[email protected]
1 parent e36fa93 commit 310d041

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/test/isolation/expected/intra-grant-inplace.out

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ step revoke4: <... completed>
226226
starting permutation: b1 drop1 b3 sfu3 revoke4 c1 r3
227227
step b1: BEGIN;
228228
step drop1:
229-
DROP TABLE intra_grant_inplace;
229+
DELETE FROM pg_class WHERE relname = 'intra_grant_inplace';
230230

231231
step b3: BEGIN ISOLATION LEVEL READ COMMITTED;
232232
step sfu3:
@@ -248,6 +248,6 @@ relhasindex
248248
-----------
249249
(0 rows)
250250

251-
s4: WARNING: got: relation "intra_grant_inplace" does not exist
251+
s4: WARNING: got: cache lookup failed for relation REDACTED
252252
step revoke4: <... completed>
253253
step r3: ROLLBACK;

src/test/isolation/specs/intra-grant-inplace.spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ step grant1 {
2020
GRANT SELECT ON intra_grant_inplace TO PUBLIC;
2121
}
2222
step drop1 {
23-
DROP TABLE intra_grant_inplace;
23+
DELETE FROM pg_class WHERE relname = 'intra_grant_inplace';
2424
}
2525
step c1 { COMMIT; }
2626

0 commit comments

Comments
 (0)