[CF 5986] v5 - vacuumdb --missing-stats-only and permission issue

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5986

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Corey Huinker

Author: Commitfest Bot

doc/src/sgml/ref/vacuumdb.sgml

@@ -292,6 +292,14 @@ PostgreSQL documentation
         This option can only be used in conjunction with
         <option>--analyze-only</option> or <option>--analyze-in-stages</option>.
        </para>
+       <para>
+        Note that <option>--missing-stats-only</option> requires
+        <literal>SELECT</literal> privileges on
+        <link linkend="catalog-pg-statistic"><structname>pg_statistic</structname></link>
+        and
+        <link linkend="catalog-pg-statistic-ext-data"><structname>pg_statistic_ext_data</structname></link>,
+        which are restricted to superusers by default.
+       </para>
       </listitem>
      </varlistentry>
 

src/bin/scripts/vacuumdb.c

@@ -801,6 +801,30 @@ retrieve_objects(PGconn *conn, vacuumingOptions *vacopts,
 	SimpleStringList *found_objs = palloc0(sizeof(SimpleStringList));
 	bool		objects_listed = false;
 
+	if (vacopts->missing_stats_only)
+	{
+		PQExpBufferData aclcheck;
+
+		initPQExpBuffer(&aclcheck);
+		appendPQExpBufferStr(&aclcheck,
+							 "SELECT has_table_privilege('pg_catalog.pg_statistic', 'select'), "
+							 "has_table_privilege('pg_catalog.pg_statistic_ext_data', 'select')");
+		res = executeQuery(conn, aclcheck.data, echo);
+		termPQExpBuffer(&aclcheck);
+		if (strcmp(PQgetvalue(res, 0, 0), "t") != 0)
+		{
+			PQfinish(conn);
+			pg_fatal("--missing-stats-only requires SELECT privileges on pg_statistic");
+		}
+		else if (strcmp(PQgetvalue(res, 0, 1), "t") != 0)
+		{
+			PQfinish(conn);
+			pg_fatal("--missing-stats-only requires SELECT privileges on pg_statistic_ext_data");
+		}
+
+		termPQExpBuffer(&aclcheck);
+	}
+
 	initPQExpBuffer(&catalog_query);
 	for (cell = objects ? objects->head : NULL; cell; cell = cell->next)
 	{