Skip to content

Commit fcb6db8

Browse files
jianhe-funCommitfest Bot
authored andcommitted
error safe for casting bigint to other types per pg_cast
select castsource::regtype, casttarget::regtype, castfunc, castcontext,castmethod, pp.prosrc, pp.proname from pg_cast pc join pg_proc pp on pp.oid = pc.castfunc and pc.castfunc > 0 and castsource::regtype = 'bigint'::regtype order by castsource::regtype; castsource | casttarget | castfunc | castcontext | castmethod | prosrc | proname ------------+------------------+----------+-------------+------------+--------------+--------- bigint | smallint | 714 | a | f | int82 | int2 bigint | integer | 480 | a | f | int84 | int4 bigint | real | 652 | i | f | i8tof | float4 bigint | double precision | 482 | i | f | i8tod | float8 bigint | numeric | 1781 | i | f | int8_numeric | numeric bigint | money | 3812 | a | f | int8_cash | money bigint | oid | 1287 | i | f | i8tooid | oid bigint | regproc | 1287 | i | f | i8tooid | oid bigint | regprocedure | 1287 | i | f | i8tooid | oid bigint | regoper | 1287 | i | f | i8tooid | oid bigint | regoperator | 1287 | i | f | i8tooid | oid bigint | regclass | 1287 | i | f | i8tooid | oid bigint | regcollation | 1287 | i | f | i8tooid | oid bigint | regtype | 1287 | i | f | i8tooid | oid bigint | regconfig | 1287 | i | f | i8tooid | oid bigint | regdictionary | 1287 | i | f | i8tooid | oid bigint | regrole | 1287 | i | f | i8tooid | oid bigint | regnamespace | 1287 | i | f | i8tooid | oid bigint | regdatabase | 1287 | i | f | i8tooid | oid bigint | bytea | 6369 | e | f | int8_bytea | bytea bigint | bit | 2075 | e | f | bitfromint8 | bit (21 rows) already error safe: i8tof, i8tod, int8_numeric, int8_bytea, bitfromint8 discussion: https://postgr.es/m/CADkLM=fv1JfY4Ufa-jcwwNbjQixNViskQ8jZu3Tz_p656i_4hQ@mail.gmail.com
1 parent d843b0f commit fcb6db8

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

src/backend/utils/adt/int8.c

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1204,10 +1204,14 @@ int84(PG_FUNCTION_ARGS)
12041204
int64 arg = PG_GETARG_INT64(0);
12051205

12061206
if (unlikely(arg < PG_INT32_MIN) || unlikely(arg > PG_INT32_MAX))
1207-
ereport(ERROR,
1207+
{
1208+
errsave(fcinfo->context,
12081209
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
12091210
errmsg("integer out of range")));
12101211

1212+
PG_RETURN_NULL();
1213+
}
1214+
12111215
PG_RETURN_INT32((int32) arg);
12121216
}
12131217

@@ -1225,10 +1229,14 @@ int82(PG_FUNCTION_ARGS)
12251229
int64 arg = PG_GETARG_INT64(0);
12261230

12271231
if (unlikely(arg < PG_INT16_MIN) || unlikely(arg > PG_INT16_MAX))
1228-
ereport(ERROR,
1232+
{
1233+
errsave(fcinfo->context,
12291234
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
12301235
errmsg("smallint out of range")));
12311236

1237+
PG_RETURN_NULL();
1238+
}
1239+
12321240
PG_RETURN_INT16((int16) arg);
12331241
}
12341242

@@ -1308,10 +1316,14 @@ i8tooid(PG_FUNCTION_ARGS)
13081316
int64 arg = PG_GETARG_INT64(0);
13091317

13101318
if (unlikely(arg < 0) || unlikely(arg > PG_UINT32_MAX))
1311-
ereport(ERROR,
1319+
{
1320+
errsave(fcinfo->context,
13121321
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
13131322
errmsg("OID out of range")));
13141323

1324+
PG_RETURN_NULL();
1325+
}
1326+
13151327
PG_RETURN_OID((Oid) arg);
13161328
}
13171329

0 commit comments

Comments
 (0)