Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5638~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5638
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 12, 2025

  1. 1/1] Minor rework of ALTER TABLE SET RelOptions code 

    1. `isnull` variable is actually needed in a very narrow scope, so
it is better to keep it in that scope, not keeping it in mind in while
dealing with the rest of the code.

2. Toast table RelOptions are never altered directly with ALTER command.
One should do ATLER to a heap relation and use toast. reloption namespace
to address toast's reloption. If you get `ATExecSetRelOptions` called with
`RELKIND_TOASTVALUE` relation in the args, something is really wrong. We
should throw asserts, errors and whistle as loud as we can.
    @nataraj-hates-MS-for-stealing-github
    nataraj-hates-MS-for-stealing-github authored and Commitfest Bot committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    67dd741 View commit details
    Browse the repository at this point in the history

  2. [CF 5638] Minor rework of ALTER TABLE SET RelOptions code 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5638

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/1913854.tdWV9SEqCh@thinkpad-pgpro
Author(s): Nikolay Shaplov
    Commitfest Bot committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    0cc29da View commit details
    Browse the repository at this point in the history
Loading