Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5810~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5810
Choose a head ref
  • 6 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 4, 2025

  1. Add tab completion for ALTER TABLE ... ALTER COLUMN ... RESET 

    Unlike SET, it only takes parenthesised attribute options.
    @ilmari
    ilmari authored and Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    508dfc5 View commit details
    Browse the repository at this point in the history

  2. Add tab completion for ALTER FOREIGN TABLE ... SET 

    The schema is the only thing that can be set for foreign tables.
    @ilmari
    ilmari authored and Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    db469f0 View commit details
    Browse the repository at this point in the history

  3. Improve tab completion for RESET 

    Only complete variables that have been set in the current session,
plus the keywords ALL, ROLE and SESSION (which will subsequently be
completed with AUTHORIZATION).

Because we're using Matches() insted of TailMatches(), we can also get
rid of the guards against ALTER DATABASE|USER|ROLE ... RESET.
    @ilmari
    ilmari authored and Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    0efe3bd View commit details
    Browse the repository at this point in the history

  4. Improve tab completion for ALTER SYSTEM RESET 

    Only complete variables where sourcefile is `postgresql.conf.auto` in
the data directory.
    @ilmari
    ilmari authored and Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    1cffeeb View commit details
    Browse the repository at this point in the history

  5. Improve tab completion for ALTER SYSTEM RESET for non-superusers 

    Non-superusers can only use ALTER SYSTEM on variables they've
explicitly been GRANTed access to, and can't read the data_directory
setting or pg_settings.sourceline column, so the existing tab
completion for ALTER SYSTEM isn't very useful for them.

Instead, query pg_parameter_acl to show the variables they do have
permission to set via ALTER SYSTEM.
    @ilmari
    ilmari authored and Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    a573585 View commit details
    Browse the repository at this point in the history

  6. [CF 5810] v5 - Improve tab completion for various SET/RESET forms 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5810

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Dagfinn Ilmari Mannsåker
    Commitfest Bot committed Nov 4, 2025
    Configuration menu
    Copy the full SHA
    23656cd View commit details
    Browse the repository at this point in the history
Loading