Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5861~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5861
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Jul 13, 2025

  1. Introduce heap-specific wrapper for visibilitymap_set() 

    visibilitymap_set(), which sets bits in the visibility map corresponding
to the heap block of the table passed in, arguably breaks a few of the
coding rules for modifying and WAL logging buffers set out in
access/transam/README.

In several of the places where visibilitymap_set() is called, setting
the heap page PD_ALL_VISIBLE and marking the buffer dirty are done
outside of a critical section.

In some places before visibilitymap_set() is called, MarkBufferDirty()
is used when MarkBufferDirtyHint() would be appropriate.

And in some places where PD_ALL_VISIBLE may already be set and we don't
mark the buffer dirty, when checksums/wal_log_hints are enabled
visibilitymap_set() will still set the heap page LSN -- even though it
was correct not to set the buffer dirty.

Besides all of these issues, having these operations open-coded all over
the place is error-prone. This commit introduces a wrapper that does the
correct operations to the heap page itself and invokes
visibilitymap_set() to make changes to the VM page.
    @melanieplageman
    melanieplageman authored and Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    3c6d276 View commit details
    Browse the repository at this point in the history

  2. [CF 5861] v2 - Fix some inconsistencies with open-coded visibilitymap… 

    …_set() callers

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5861

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAAKRu_awNQte98bXxrzZFwaC6h+GOxCHkO6E=bK=06MDE3B8zg@mail.gmail.com
Author(s): Melanie Plageman
    Commitfest Bot committed Jul 13, 2025
    Configuration menu
    Copy the full SHA
    a62c4b0 View commit details
    Browse the repository at this point in the history
Loading