Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5970~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5970
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 30, 2025

  1. Pre-check potential XLogRecord oversize for heap_update and heap_insert. 

    Pre-check potential XLogRecord oversize. XLogRecord will be created
later, and it's size will be checked. However, this operation will
occur within a critical section, and in the event of failure, a core
dump will be generated.
It does't seem good, so to avoid this, we can calculate the approximate
xlog record size here and check it.

Size prediction is based on xlog update and xlog delete logic, and can
be revised if it changes. For now, the buf size is limited by
UINT16_MAX (Assert(regbuf->rdata_len <= UINT16_MAX) in xloginsert).

Anyway, to accommodate some overhead, 1M is subtracted from the predicted
value. It seems like that's enough for now.
    @manaldush
    manaldush authored and Commitfest Bot committed Oct 30, 2025
    Configuration menu
    Copy the full SHA
    1d1c527 View commit details
    Browse the repository at this point in the history

  2. [CF 5970] v3 - Panic during xlog building with big values 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/5970

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Maksim Melnikov
    Commitfest Bot committed Oct 30, 2025
    Configuration menu
    Copy the full SHA
    6262e03 View commit details
    Browse the repository at this point in the history
Loading