Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6009~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6009
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 29, 2025

  1. Make LWLockCounter a global variable. 

    In lwlock.c, using the LWLockCounter requires first calculating its
address in shared memory like this:

	LWLockCounter = (int *) ((char *) MainLWLockArray - sizeof(int));

Commit 82e861f started this trend in order to fix EXEC_BACKEND
builds, but it could also be fixed by adding it to the
BackendParameters struct.  The current approach is somewhat
difficult to follow, so this commit switches to the latter
approach.  While at it, swap around the code in LWLockShmemSize()
to match the order of the assignments in CreateLWLocks() for added
readability.

Reviewed-by: Tom Lane <[email protected]>
Reviewed-by: Bertrand Drouvot <[email protected]>
Discussion: https://postgr.es/m/aLDLnan9gNCS9fHx%40nathan
    @nathan-bossart
    nathan-bossart authored and Commitfest Bot committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    0baaf85 View commit details
    Browse the repository at this point in the history

  2. [CF 6009] v2 - make LWLockCounter a global variable 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6009

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/aLG8jlpEZAseM-wk@nathan
Author(s): Nathan Bossart
    Commitfest Bot committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    acb9d5d View commit details
    Browse the repository at this point in the history
Loading