Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6074~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6074
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on Oct 29, 2025

  1. Refactor dependency recording to enable dependency collection 

    Add new function collectDependenciesFromExpr() that collects object
dependencies into caller-supplied ObjectAddresses structures without
immediately recording them.

This enables more flexible dependency handling patterns where callers
need to examine, filter, or modify dependencies before recording them.
The existing recordDependencyOnExpr() function is reimplemented using
the new collection function, maintaining full backward compatibility.

This refactoring lays the groundwork for enhanced dependency validation
in SQL functions while preserving all existing functionality.
    @jimjonesbr
    jimjonesbr authored and Commitfest Bot committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    063e4ce View commit details
    Browse the repository at this point in the history

  2. Prevent SQL functions with BEGIN ATOMIC from depending on temporary o… 

    …bjects

SQL functions with BEGIN ATOMIC bodies are intended to be permanently
definable and should not depend on session-specific temporary objects.
This commit implements dependency validation to enforce this restriction.

Key changes:
- Add filter_temp_objects() to detect temporary objects (tables, views, types,
  functions, sequences, domains) and raise descriptive errors
- Integrate temp object filtering into ProcedureCreate() for SQL functions
  with BEGIN ATOMIC bodies
- Allow temp-to-temp references: functions in temporary schemas can reference
  temporary objects since both have the same session lifecycle
- Skip filtering during bootstrap and pg_upgrade to avoid interfering with
  system operations
- Preserve existing behavior for regular SQL functions and parameter defaults

The implementation leverages the existing collectDependenciesFromExpr()
infrastructure to collect dependencies before applying temp object validation,
using a collect-then-filter-then-record pattern for SQL function bodies.
    @jimjonesbr
    jimjonesbr authored and Commitfest Bot committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    f90b375 View commit details
    Browse the repository at this point in the history

  3. [CF 6074] v5 - Disallow BEGIN ATOMIC SQL functions depending on temp … 

    …relations

This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6074

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/[email protected]
Author(s): Jim Jones
    Commitfest Bot committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    b0253c7 View commit details
    Browse the repository at this point in the history
Loading