Skip to content

Commit 6a86002

Browse files
committed
Update to latest lints
1 parent 21df6da commit 6a86002

12 files changed

+19
-19
lines changed

packages/sqlite_async/lib/src/common/isolate_connection_factory.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ abstract class IsolateConnectionFactory<Database extends sqlite.CommonDatabase>
3030
SerializedPortClient get upstreamPort;
3131

3232
factory IsolateConnectionFactory(
33-
{required openFactory,
34-
required mutex,
33+
{required dynamic /* platform-specific type */ openFactory,
34+
required /* platform-specific type */ mutex,
3535
required SerializedPortClient upstreamPort}) {
3636
return IsolateConnectionFactoryImpl(
3737
openFactory: openFactory,

packages/sqlite_async/lib/src/common/port_channel_native.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class ParentPortClient implements PortClient {
128128
_close();
129129
}
130130

131-
tieToIsolate(Isolate isolate) {
131+
void tieToIsolate(Isolate isolate) {
132132
_isolateDebugName = isolate.debugName;
133133
isolate.addErrorListener(_errorPort.sendPort);
134134
isolate.addOnExitListener(_receivePort.sendPort, response: _closeMessage);
@@ -207,7 +207,7 @@ class RequestPortServer {
207207

208208
RequestPortServer(this.port);
209209

210-
open(Future<Object?> Function(Object? message) handle) {
210+
PortServer open(Future<Object?> Function(Object? message) handle) {
211211
return PortServer.forSendPort(port, handle);
212212
}
213213
}

packages/sqlite_async/lib/src/common/port_channel_stub.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ParentPortClient implements PortClient {
5353
_stub();
5454
}
5555

56-
tieToIsolate(Isolate isolate) {
56+
void tieToIsolate(Isolate isolate) {
5757
_stub();
5858
}
5959
}
@@ -97,7 +97,7 @@ class RequestPortServer {
9797

9898
RequestPortServer(this.port);
9999

100-
open(Future<Object?> Function(Object? message) handle) {
100+
PortServer open(Future<Object?> Function(Object? message) handle) {
101101
_stub();
102102
}
103103
}

packages/sqlite_async/lib/src/common/sqlite_database.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ abstract class SqliteDatabase
7070
///
7171
/// A maximum of [maxReaders] concurrent read transactions are allowed.
7272
factory SqliteDatabase(
73-
{required path,
73+
{required String path,
7474
int maxReaders = SqliteDatabase.defaultMaxReaders,
7575
SqliteOptions options = const SqliteOptions.defaults()}) {
7676
return SqliteDatabaseImpl(

packages/sqlite_async/lib/src/impl/stub_sqlite_database.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class SqliteDatabaseImpl
2020
int maxReaders;
2121

2222
factory SqliteDatabaseImpl(
23-
{required path,
23+
{required String path,
2424
int maxReaders = SqliteDatabase.defaultMaxReaders,
2525
SqliteOptions options = const SqliteOptions.defaults()}) {
2626
throw UnimplementedError();

packages/sqlite_async/lib/src/native/database/native_sqlite_database.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class SqliteDatabaseImpl
5454
///
5555
/// A maximum of [maxReaders] concurrent read transactions are allowed.
5656
factory SqliteDatabaseImpl(
57-
{required path,
57+
{required String path,
5858
int maxReaders = SqliteDatabase.defaultMaxReaders,
5959
SqliteOptions options = const SqliteOptions.defaults()}) {
6060
final factory =

packages/sqlite_async/lib/src/native/native_isolate_connection_factory.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class _IsolateUpdateListener {
7575
return controller.stream;
7676
}
7777

78-
close() {
78+
void close() {
7979
client.fire(UnsubscribeToUpdates(port.sendPort));
8080
controller.close();
8181
port.close();

packages/sqlite_async/lib/src/native/native_isolate_mutex.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class SharedMutex implements Mutex {
159159
}, zoneValues: {this: true});
160160
}
161161

162-
_unlock() {
162+
void _unlock() {
163163
client.fire(const _UnlockMessage());
164164
}
165165

packages/sqlite_async/lib/src/sqlite_migrations.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class SqliteMigrations {
2525

2626
SqliteMigrations({this.migrationTable = "_migrations"});
2727

28-
add(SqliteMigration migration) {
28+
void add(SqliteMigration migration) {
2929
assert(
3030
migrations.isEmpty || migrations.last.toVersion < migration.toVersion);
3131

@@ -48,7 +48,7 @@ class SqliteMigrations {
4848
}
4949

5050
/// The current version as specified by the migrations.
51-
get version {
51+
int get version {
5252
return migrations.isEmpty ? 0 : migrations.last.toVersion;
5353
}
5454

@@ -68,7 +68,7 @@ class SqliteMigrations {
6868
}
6969
}
7070

71-
_validateCreateDatabase() {
71+
void _validateCreateDatabase() {
7272
if (createDatabase != null) {
7373
if (createDatabase!.downMigration != null) {
7474
throw MigrationError("createDatabase may not contain down migrations");
@@ -229,7 +229,7 @@ class SqliteDownMigration {
229229
SqliteDownMigration({required this.toVersion});
230230

231231
/// Add an statement to execute to downgrade the database version.
232-
add(String sql, [List<Object?>? params]) {
232+
void add(String sql, [List<Object?>? params]) {
233233
_statements.add(_SqliteMigrationStatement(sql, params ?? []));
234234
}
235235
}

packages/sqlite_async/lib/src/web/database/web_sqlite_database.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class SqliteDatabaseImpl
5656
///
5757
/// A maximum of [maxReaders] concurrent read transactions are allowed.
5858
factory SqliteDatabaseImpl(
59-
{required path,
59+
{required String path,
6060
int maxReaders = SqliteDatabase.defaultMaxReaders,
6161
SqliteOptions options = const SqliteOptions.defaults()}) {
6262
final factory =

0 commit comments

Comments
 (0)