1- From bc2a85e39fd55879b9baed51429c08b27d5514c8 Mon Sep 17 00:00:00 2001
1+ From 2626f194c5368aa51b93e4d558dcc4de493ad9a0 Mon Sep 17 00:00:00 2001
22From: Matt Leon <
[email protected] >
33Date: Wed, 16 Jul 2025 16:55:02 -0400
44Subject: [PATCH 1/7] Disable pointer compression
1111 1 file changed, 1 insertion(+), 1 deletion(-)
1212
1313diff --git a/BUILD.bazel b/BUILD.bazel
14- index 3f5a87d054e..0a693b7ee10 100644
14+ index d49da552c42..02a599386f4 100644
1515--- a/BUILD.bazel
1616+++ b/BUILD.bazel
17- @@ -292 ,7 +292 ,7 @@ v8_int(
17+ @@ -296 ,7 +296 ,7 @@ v8_int(
1818 # If no explicit value for v8_enable_pointer_compression, we set it to 'none'.
1919 v8_string(
2020 name = "v8_enable_pointer_compression",
@@ -24,10 +24,10 @@ index 3f5a87d054e..0a693b7ee10 100644
2424
2525 # Default setting for v8_enable_pointer_compression.
2626- -
27- 2.50 .0.727.gbf7dc18ff4 -goog
27+ 2.52 .0.239.gd5f0c6e74e -goog
2828
2929
30- From 61898e9a63ac89a37261c081b84714cfc400a4b1 Mon Sep 17 00:00:00 2001
30+ From cbc8ec687fda83030be2e322e5ccd96058b21a9f Mon Sep 17 00:00:00 2001
3131From: Matt Leon <
[email protected] >
3232Date: Wed, 16 Jul 2025 16:56:31 -0400
3333Subject: [PATCH 2/7] Restore _allowlist_function_transition
4343 2 files changed, 14 insertions(+)
4444
4545diff --git a/bazel/defs.bzl b/bazel/defs.bzl
46- index 0539ea176ac..14d7ace5e59 100644
46+ index a7e1e2af786..ba8315bb938 100644
4747--- a/bazel/defs.bzl
4848+++ b/bazel/defs.bzl
49- @@ -485 ,6 +485 ,9 @@ _v8_mksnapshot = rule(
49+ @@ -491 ,6 +491 ,9 @@ _v8_mksnapshot = rule(
5050 cfg = "exec",
5151 ),
5252 "target_os": attr.string(mandatory = True),
@@ -79,10 +79,10 @@ index 8c929454840..57336154cf7 100644
7979 # Making this executable means it works with "$ bazel run".
8080 executable = True,
8181- -
82- 2.50 .0.727.gbf7dc18ff4 -goog
82+ 2.52 .0.239.gd5f0c6e74e -goog
8383
8484
85- From 4a6e7158fd4ca48c75c8e33ea15760c9beea1d2f Mon Sep 17 00:00:00 2001
85+ From 670535cf36232fd6907979941b4df47fdd85f54a Mon Sep 17 00:00:00 2001
8686From: Matt Leon <
[email protected] >
8787Date: Wed, 16 Jul 2025 16:56:52 -0400
8888Subject: [PATCH 3/7] Don't expose Wasm C API (only Wasm C++ API).
9393 1 file changed, 4 insertions(+)
9494
9595diff --git a/src/wasm/c-api.cc b/src/wasm/c-api.cc
96- index 05e4029f183..d705be96a16 100644
96+ index 0f8a374840b..b8dd6bf12cd 100644
9797--- a/src/wasm/c-api.cc
9898+++ b/src/wasm/c-api.cc
99- @@ -2472 ,6 +2472 ,8 @@ WASM_EXPORT auto Instance::exports() const -> ownvec<Extern> {
99+ @@ -2480 ,6 +2480 ,8 @@ WASM_EXPORT auto Instance::exports() const -> ownvec<Extern> {
100100
101101 } // namespace wasm
102102
@@ -105,17 +105,17 @@ index 05e4029f183..d705be96a16 100644
105105 // BEGIN FILE wasm-c.cc
106106
107107 extern "C" {
108- @@ -3518 ,3 +3520 ,5 @@ wasm_instance_t* wasm_frame_instance(const wasm_frame_t* frame) {
108+ @@ -3526 ,3 +3528 ,5 @@ wasm_instance_t* wasm_frame_instance(const wasm_frame_t* frame) {
109109 #undef WASM_DEFINE_SHARABLE_REF
110110
111111 } // extern "C"
112112+
113113+ #endif
114114- -
115- 2.50 .0.727.gbf7dc18ff4 -goog
115+ 2.52 .0.239.gd5f0c6e74e -goog
116116
117117
118- From 7b593eb8086dcfe9012d4fa694d622f21dadb731 Mon Sep 17 00:00:00 2001
118+ From ebdb202f6d6a3182afbdfa50167323d0794f56ec Mon Sep 17 00:00:00 2001
119119From: Matt Leon <
[email protected] >
120120Date: Wed, 16 Jul 2025 16:58:02 -0400
121121Subject: [PATCH 4/7] Stub out fast_float for bazel-supplied version
126126 1 file changed, 1 insertion(+), 1 deletion(-)
127127
128128diff --git a/BUILD.bazel b/BUILD.bazel
129- index 0a693b7ee10..eafd9dad20c 100644
129+ index 02a599386f4..96326070dc1 100644
130130--- a/BUILD.bazel
131131+++ b/BUILD.bazel
132- @@ -4438 ,7 +4438 ,7 @@ v8_library(
132+ @@ -4531 ,7 +4531 ,7 @@ v8_library(
133133 ],
134134 deps = [
135135 ":lib_dragonbox",
@@ -139,10 +139,10 @@ index 0a693b7ee10..eafd9dad20c 100644
139139 ":simdutf",
140140 ":v8_libbase",
141141- -
142- 2.50 .0.727.gbf7dc18ff4 -goog
142+ 2.52 .0.239.gd5f0c6e74e -goog
143143
144144
145- From b442d34b12dd513946f509d9db86839ce8aa4d7f Mon Sep 17 00:00:00 2001
145+ From c9c069992e9472b0d91203bddea083d264ef1317 Mon Sep 17 00:00:00 2001
146146From: Matt Leon <
[email protected] >
147147Date: Wed, 16 Jul 2025 20:04:05 -0400
148148Subject: [PATCH 5/7] Stub out vendored dependencies for bazel-sourced versions
153153 1 file changed, 3 insertions(+), 3 deletions(-)
154154
155155diff --git a/BUILD.bazel b/BUILD.bazel
156- index eafd9dad20c..ce36666e36e 100644
156+ index 96326070dc1..48b2824c107 100644
157157--- a/BUILD.bazel
158158+++ b/BUILD.bazel
159- @@ -4437 ,10 +4437 ,10 @@ v8_library(
159+ @@ -4530 ,10 +4530 ,10 @@ v8_library(
160160 ":noicu/generated_torque_definitions",
161161 ],
162162 deps = [
@@ -171,10 +171,10 @@ index eafd9dad20c..ce36666e36e 100644
171171 "@abseil-cpp//absl/container:btree",
172172 "@abseil-cpp//absl/container:flat_hash_map",
173173- -
174- 2.50 .0.727.gbf7dc18ff4 -goog
174+ 2.52 .0.239.gd5f0c6e74e -goog
175175
176176
177- From e0b8f32cc057a3c0875437d5d54d012cabcab458 Mon Sep 17 00:00:00 2001
177+ From b4050d95d32dbcbd43d3c205b8b424d43757becd Mon Sep 17 00:00:00 2001
178178From: Matt Leon <
[email protected] >
179179Date: Wed, 16 Jul 2025 20:29:10 -0400
180180Subject: [PATCH 6/7] Add build flags to make V8 compile with GCC
185185 1 file changed, 3 insertions(+)
186186
187187diff --git a/bazel/defs.bzl b/bazel/defs.bzl
188- index 14d7ace5e59..c7a48d4e805 100644
188+ index ba8315bb938..277a07ef63d 100644
189189--- a/bazel/defs.bzl
190190+++ b/bazel/defs.bzl
191- @@ -117,6 +117,9 @@ def _default_args():
192- "-Wno-implicit-int-float-conversion",
191+ @@ -123,6 +123,9 @@ def _default_args():
193192 "-Wno-deprecated-copy",
194193 "-Wno-non-virtual-dtor",
194+ "-Wno-unnecessary-virtual-specifier",
195195+ "-Wno-invalid-offsetof",
196196+ "-Wno-dangling-pointer",
197197+ "-Wno-dangling-reference",
198198 "-isystem .",
199199 ],
200200 "//conditions:default": [],
201201- -
202- 2.50 .0.727.gbf7dc18ff4 -goog
202+ 2.52 .0.239.gd5f0c6e74e -goog
203203
204204
205- From 7ce2d6bd14b338ab91a8636a8694b9ef180b2f90 Mon Sep 17 00:00:00 2001
205+ From 1d9136af513e84f9874f3b816159e9d5f67cc66e Mon Sep 17 00:00:00 2001
206206From: Matt Leon <
[email protected] >
207207Date: Fri, 18 Jul 2025 17:28:42 -0400
208208Subject: [PATCH 7/7] Hack out atomic simd support in V8.
230230 3 files changed, 19 insertions(+), 1 deletion(-)
231231
232232diff --git a/bazel/defs.bzl b/bazel/defs.bzl
233- index c7a48d4e805..a73b3812882 100644
233+ index 277a07ef63d..0617ecf1607 100644
234234--- a/bazel/defs.bzl
235235+++ b/bazel/defs.bzl
236- @@ -180 ,7 +180 ,7 @@ def _default_args():
236+ @@ -186 ,7 +186 ,7 @@ def _default_args():
237237 "Advapi32.lib",
238238 ],
239239 "@v8//bazel/config:is_macos": ["-pthread"],
@@ -243,10 +243,10 @@ index c7a48d4e805..a73b3812882 100644
243243 ":should_add_rdynamic": ["-rdynamic"],
244244 "//conditions:default": [],
245245diff --git a/src/builtins/builtins-typed-array.cc b/src/builtins/builtins-typed-array.cc
246- index 918cb873481..bc933e8dc1d 100644
246+ index 146e3f28541..4924e8137c4 100644
247247--- a/src/builtins/builtins-typed-array.cc
248248+++ b/src/builtins/builtins-typed-array.cc
249- @@ -520 ,17 +520 ,21 @@ simdutf::result ArrayBufferSetFromBase64(
249+ @@ -505 ,17 +505 ,21 @@ simdutf::result ArrayBufferSetFromBase64(
250250 DirectHandle<JSTypedArray> typed_array, size_t& output_length) {
251251 output_length = array_length;
252252 simdutf::result simd_result;
@@ -268,19 +268,19 @@ index 918cb873481..bc933e8dc1d 100644
268268
269269 return simd_result;
270270 }
271- @@ -833 ,15 +837 ,19 @@ BUILTIN(Uint8ArrayPrototypeToBase64) {
271+ @@ -835 ,15 +839 ,19 @@ BUILTIN(Uint8ArrayPrototypeToBase64) {
272272 // 11. Return CodePointsToString(outAscii).
273273
274274 size_t simd_result_size;
275275+ #ifdef WANT_ATOMIC_REF
276276 if (uint8array->buffer()->is_shared()) {
277277 simd_result_size = simdutf::atomic_binary_to_base64(
278- std::bit_cast <const char*>(uint8array->DataPtr()), length,
278+ reinterpret_cast <const char*>(uint8array->DataPtr()), length,
279279 reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
280280 } else {
281281+ #endif
282282 simd_result_size = simdutf::binary_to_base64(
283- std::bit_cast <const char*>(uint8array->DataPtr()), length,
283+ reinterpret_cast <const char*>(uint8array->DataPtr()), length,
284284 reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
285285+ #ifdef WANT_ATOMIC_REF
286286 }
@@ -289,7 +289,7 @@ index 918cb873481..bc933e8dc1d 100644
289289 USE(simd_result_size);
290290 }
291291diff --git a/src/objects/simd.cc b/src/objects/simd.cc
292- index 0ef570ceb7d..9217fa76072 100644
292+ index ef2b8118eec..68115031f1a 100644
293293--- a/src/objects/simd.cc
294294+++ b/src/objects/simd.cc
295295@@ -477,6 +477,7 @@ void Uint8ArrayToHexSlow(const char* bytes, size_t length,
@@ -308,7 +308,7 @@ index 0ef570ceb7d..9217fa76072 100644
308308
309309 inline uint16_t ByteToHex(uint8_t byte) {
310310 const uint16_t correction = (('a' - '0' - 10) << 8) + ('a' - '0' - 10);
311- @@ -645 ,11 +647 ,15 @@ Tagged<Object> Uint8ArrayToHex(const char* bytes, size_t length, bool is_shared,
311+ @@ -647 ,11 +649 ,15 @@ Tagged<Object> Uint8ArrayToHex(const char* bytes, size_t length, bool is_shared,
312312 }
313313 #endif
314314
@@ -324,7 +324,7 @@ index 0ef570ceb7d..9217fa76072 100644
324324 return *string_output;
325325 }
326326
327- @@ -1082 ,12 +1088 ,16 @@ bool ArrayBufferFromHex(const base::Vector<T>& input_vector, bool is_shared,
327+ @@ -1084 ,12 +1090 ,16 @@ bool ArrayBufferFromHex(const base::Vector<T>& input_vector, bool is_shared,
328328 for (uint32_t i = 0; i < output_length * 2; i += 2) {
329329 result = HandleRemainingHexValues(input_vector, i);
330330 if (result.has_value()) {
@@ -342,5 +342,5 @@ index 0ef570ceb7d..9217fa76072 100644
342342 return false;
343343 }
344344- -
345- 2.50 .0.727.gbf7dc18ff4 -goog
345+ 2.52 .0.239.gd5f0c6e74e -goog
346346
0 commit comments