From 907afca50ad74c26fabf43a90ed96d47d49a17e2 Mon Sep 17 00:00:00 2001 From: Piotr Sikora Date: Sun, 6 Feb 2022 14:43:11 -0800 Subject: [PATCH 1/2] wasmtime: test on Linux/s390x. Signed-off-by: Piotr Sikora --- .github/workflows/cpp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml index 2840113cc..556f2dc5c 100644 --- a/.github/workflows/cpp.yml +++ b/.github/workflows/cpp.yml @@ -109,7 +109,7 @@ jobs: repo: 'com_github_bytecodealliance_wasmtime' os: ubuntu-20.04 arch: s390x - action: build + action: test run_under: docker run --rm --env HOME=$HOME --env USER=$(id -un) --volume "$HOME:$HOME" --workdir $(pwd) --user $(id -u):$(id -g) --platform linux/s390x piotrsikora/build-tools:bazel-5.0.0-clang-13-gcc-11 - name: 'Wasmtime on macOS/x86_64' runtime: 'wasmtime' From 8ded2d434587bc2dd6bc2944bf3d1bf31a897339 Mon Sep 17 00:00:00 2001 From: Piotr Sikora Date: Sun, 6 Feb 2022 16:14:25 -0800 Subject: [PATCH 2/2] review: fix signature verification on big-endian platforms. Signed-off-by: Piotr Sikora --- src/signature_util.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/signature_util.cc b/src/signature_util.cc index 7e3e1d976..9163c4661 100644 --- a/src/signature_util.cc +++ b/src/signature_util.cc @@ -85,6 +85,7 @@ bool SignatureUtil::verifySignature(std::string_view bytecode, std::string &mess uint32_t alg_id; std::memcpy(&alg_id, payload.data(), sizeof(uint32_t)); + alg_id = le32toh(alg_id); if (alg_id != 2) { message = "Signature has a wrong alg_id (want: 2, is: " + std::to_string(alg_id) + ")";