Release branch merge back for 2.1.2

(maint) Modulesync update

This commit adds a github pull request template to help users submit correctly formatted PR to our projects

(maint) modulesync 892c4cf

(maint) Add Github Pull Request Template

Prior to this commit, the timeout waiting for PowerShell to start
was only 10 seconds; this was not, in practice, a long enough
period of time for multiple customers, especially when a node is
under heavy load. This commit increases the timeout to 30 seconds.

This commit renames the PowerShell binary name from PowerShell to
pwsh. This is because the name of the binary has changed in the
latest PowerShell betas. This commit also removes the manual checking
of specific paths like /usr/local/bin for the pwsh executable.
Instead for non Windows platforms we simply call pwsh and let the
platform do the path resolution based on current PATH settings. One
reason to switch to this behavior is the Mac OS X preferences
for ordering /usr/local/bin in path before /usr/bin, as some other
platforms do. The PATH checking in Windows was for specific use case
and we decided that absent that use case in other platforms, it should
be removed so that users get the behavior they expect based on their
platform, and not on internal Puppet logic.

…ename-ps-executable

(MODULES-6081) Rename PowerShell executable

…748-increase-timeout-for-powershell

(MODULES-4748) Increase timeout for opening PowerShell

Prior to this commit if a timeout occurs while waiting for the
connection to a named pipe then a zombie process is left on the
system as the code to close or kill it is never called. This commit
ensures that such zombie processes are removed before the error is
raised.

This commit also adds an RSPEC test to validate that if we try to
create a manager with an unreasonably low timeout value, that the
manager will not have time to open the pipes server and it will
fail to create the manager and further verify that no zombie
processes are left running.

Paired-with: Bill Hurt <[email protected]>

…748-cleanup-zombies

(MODULES-4748) Prevent zombie procs from timeout

This commit updates the CHANGELOG and metadata.json in preparation
for the supported `2.1.3` release.