This repository was archived by the owner on Sep 10, 2024. It is now read-only.
Ensure checksum is 2 digits #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where some L76 messages are ignored due to the checksum being one digit long (i.e. 'F') vs. the expected 2 digit length ('0F')
(Hi! 👋 Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.)
What does this implement/fix? Explain your changes.
Sometimes, messages written to the L76 are ignored due to an invalid checksum
Does this close any currently open issues?
None afaik
Any relevant logs, error output, etc?
(If it’s long, please paste to https://gist.github.com and insert the link here)
l76.write("PMTK740,{},{},{},{},{},{}".format(curtime[0], curtime[1], curtime[2], curtime[3], curtime[4], curtime[5]))used to result in$PMTK740,2021,4,8,19,0,57*6being sent, which was missing the second checksum digit, causing the message to be ignoredAny other comments?
Where has this been tested?
Pytrack 2.0X, GPY 1.0
os.uname()output:(sysname='GPy', nodename='GPy', release='1.20.2.r4', version='v1.11-ffb0e1c on 2021-01-12', machine='GPy with ESP32', pybytes='1.6.1')