Skip to content

gh-126014: Ignore __pycache__-only folders in makefile tests #126066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 28, 2024

Copy link
Contributor

@furkanonder furkanonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :) I ran into this again today while working on some tests 😄

@sobolevn sobolevn merged commit aeafaf4 into python:main Oct 29, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2024

GH-126109 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2024

GH-126110 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 29, 2024
sobolevn added a commit that referenced this pull request Oct 29, 2024
…GH-126066) (#126110)

gh-126014: Ignore `__pycache__`-only folders in makefile tests (GH-126066)
(cherry picked from commit aeafaf4)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
sobolevn added a commit that referenced this pull request Oct 29, 2024
…GH-126066) (#126109)

gh-126014: Ignore `__pycache__`-only folders in makefile tests (GH-126066)
(cherry picked from commit aeafaf4)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants