Skip to content

gh-129917: Update installers to use SQLite 3.49 #131025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2025
Merged

gh-129917: Update installers to use SQLite 3.49 #131025

merged 9 commits into from
Mar 31, 2025

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 9, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 9, 2025
Closed
@mhsmith
Copy link
Member

mhsmith commented Mar 13, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit deb8d8e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131025%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

ned-deily
ned-deily reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the issue, since our last rev bump the SQLite project has moved from using autoconf to autosetup and that has caused various problems for downstream builders including our macOS installer build. The fixes for that were relatively simple and this PR now covers them.

@erlend-aasland erlend-aasland marked this pull request as ready for review March 30, 2025 21:57
@freakboy3742
Copy link
Contributor

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 4fe5959 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131025%2Fmerge

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

freakboy3742
freakboy3742 reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the Android perspective; The macOS and Windows changes look like they make sense, but I'm less confident that I haven't missed something subtle.

ned-deily
ned-deily approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS changes LGTM

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews. I'll land when @zooba (or anyone else from the Windows team) gives a thumbs up.

@zooba
Copy link
Member

zooba commented Mar 31, 2025

LGTM

@erlend-aasland erlend-aasland merged commit 45a3ab5 into python:main Mar 31, 2025
45 checks passed
@erlend-aasland erlend-aasland deleted the sqlite/3.49 branch March 31, 2025 21:13
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 31, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 31, 2025
@erlend-aasland @ned-deily @miss-islington
pythongh-129917: Update installers to use SQLite 3.49.1 (pythonGH-131025
d1e3a10 
)

(cherry picked from commit 45a3ab5)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 31, 2025

GH-131957 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 31, 2025
@bedevere-app
Copy link

bedevere-app bot commented Mar 31, 2025

GH-131958 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 31, 2025
erlend-aasland added a commit that referenced this pull request Mar 31, 2025
@miss-islington @erlend-aasland @ned-deily
[3.13] gh-129917: Update installers to use SQLite 3.49.1 (GH-131025) (#…
67087d9 
…131957)

gh-129917: Update installers to use SQLite 3.49.1 (GH-131025)

(cherry picked from commit 45a3ab5)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Ned Deily <[email protected]>
erlend-aasland added a commit that referenced this pull request Mar 31, 2025
@erlend-aasland @ned-deily
[3.12] gh-129917: Update installers to use SQLite 3.49.1 (#131025) (#…
b1bbd01 
…131958)

(cherry picked from commit 45a3ab5)

Co-authored-by: Ned Deily <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@erlend-aasland @ned-deily @seehwan80
pythongh-129917: Update installers to use SQLite 3.49.1 (python#131025)
2fa323d 
Co-authored-by: Ned Deily <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 left review comments

@mhsmith mhsmith mhsmith left review comments

@ned-deily ned-deily ned-deily approved these changes

@sethmlarson sethmlarson Awaiting requested review from sethmlarson sethmlarson is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @mhsmith @bedevere-bot @freakboy3742 @zooba @ned-deily