Skip to content

Commit f94d2a5

Browse files
committed
Fix narrowing conversions seen on 32bit arm
This issue is seen with clang-19 when compiling for arm32 make clang-19 happier with -Wc++11-narrowing Fixes native_skia_output_device_opengl.cpp:292:47: error: non-constant-expression cannot be narrowed from type ' ↪ uint32_t' (aka 'unsigned int') to 'EGLAttrib' (aka 'int') in initializer list [-Wc++11-narrowing] 292 | EGL_DMA_BUF_PLANE0_PITCH_EXT, nativePixmap->GetDmaBufPitch(0), Pick-to: 6.8 6.9 6.10 Change-Id: I95ba1ab0a37218b6d05324df563efba6d5c39ba2 Reviewed-by: Allan Sandfeld Jensen <[email protected]>
1 parent 242b372 commit f94d2a5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/core/compositor/native_skia_output_device_opengl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ QSGTexture *NativeSkiaOutputDeviceOpenGL::texture(QQuickWindow *win, uint32_t te
248248
EGL_LINUX_DRM_FOURCC_EXT, drmFormat,
249249
EGL_DMA_BUF_PLANE0_FD_EXT, scopedFd.get(),
250250
EGL_DMA_BUF_PLANE0_OFFSET_EXT, static_cast<EGLAttrib>(nativePixmap->GetDmaBufOffset(0)),
251-
EGL_DMA_BUF_PLANE0_PITCH_EXT, nativePixmap->GetDmaBufPitch(0),
251+
EGL_DMA_BUF_PLANE0_PITCH_EXT, static_cast<EGLAttrib>(nativePixmap->GetDmaBufPitch(0)),
252252
EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT, static_cast<EGLAttrib>(modifier & 0xffffffff),
253253
EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT, static_cast<EGLAttrib>(modifier >> 32),
254254
EGL_NONE

0 commit comments

Comments
 (0)