Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/cssbundling-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.3
Choose a base ref
...
head repository: rails/cssbundling-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.0
Choose a head ref
  • 8 commits
  • 12 files changed
  • 7 contributors

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    b27be4a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Synchronize bin/dev from jsbundling-rails to cssbundling-rails (#151)

    There are different bin/dev being generated by cssbundling-rails and jsbundling-rails
    
    See rails/jsbundling-rails#174
    
    > dev: Use an affirmative conditional
    >
    > ...and avoid regex in match.
    >
    > (Try a gem list ails vs a gem list --exact ails to see what I mean.)
    Dorian Marié authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    02caad4 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Use Thor's apply instead of a prerequisite task (#150)

    The `css:install:shared` task serves only as a prerequisite for the
    other installer tasks; it should not be run on its own (nor listed with
    `rake --tasks`).  By replacing this task with corresponding calls to
    Thor's `apply` method, we avoid the overhead of running
    `bin/rails app:template` (and `bundle install`) multiple times.
    jonathanhefner authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    7638f92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9075819 View commit details
    Browse the repository at this point in the history
  3. Fix running "rails new --css bootstrap" on 7.1 (#147)

    Rails 7.1 included a [change][1] to allow using importmaps along with
    all cssbundling options. However, the Bootstrap installer was never
    updated to take this new default into effect (and is currently broken
    because of this).
    
    This commit adds the additional configuration required to use the
    Bootstrap npm package with importmaps so that "rails new" generates an
    application that runs without errors.
    
    [1]: rails/rails@84458a8
    skipkayhil authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    3e768cd View commit details
    Browse the repository at this point in the history
  4. PNPM Support (#145)

    * Simplify build tool selection for bun / yarn
    
    Simplifying ahead of introducing NPM as a build tool.
    
    * Support for NPM
    
    * Support PNPM
    ksylvest authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e650c9a View commit details
    Browse the repository at this point in the history
  5. Bump version for 1.4.0

    dhh committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    f9e6dc4 View commit details
    Browse the repository at this point in the history
  6. Fix escaping issue with bootstrap command

    Fixed #137
    dhh committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    09d81cb View commit details
    Browse the repository at this point in the history
Loading