Skip to content

Commit 359cfbb

Browse files
committed
fix deprecated calls and provide expected messages for 0.12
1 parent 4e81aff commit 359cfbb

File tree

8 files changed

+14
-12
lines changed

8 files changed

+14
-12
lines changed

gemfiles/rails_3.1.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ source "http://rubygems.org"
55
gem "rails", "~> 3.1"
66
gem "sprockets", ">= 2.2.2"
77

8-
gemspec :path=>"../"
8+
gemspec :path => "../"

gemfiles/rails_3.2.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ source "http://rubygems.org"
44

55
gem "rails", "~> 3.2"
66

7-
gemspec :path=>"../"
7+
gemspec :path => "../"

gemfiles/rails_4.0.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ source "http://rubygems.org"
44

55
gem "rails", "~> 4.0"
66

7-
gemspec :path=>"../"
7+
gemspec :path => "../"

gemfiles/rails_4.0_with_therubyracer.gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
source "http://rubygems.org"
44

55
gem "rails", "~> 4.0"
6-
gem "therubyracer", "0.12.0", :platform=>:mri
6+
gem "therubyracer", "0.12.0", :platform => :mri
77

8-
gemspec :path=>"../"
8+
gemspec :path => "../"

gemfiles/rails_4.1.gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ source "http://rubygems.org"
44

55
gem "rails", "~> 4.1"
66

7-
gemspec :path=>"../"
7+
gemspec :path => "../"

lib/assets/javascripts/react_ujs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
var constructor = window[className] || eval.call(window, className);
2626
var propsJson = node.getAttribute(PROPS_ATTR);
2727
var props = propsJson && JSON.parse(propsJson);
28-
React.renderComponent(constructor(props), node);
28+
React.render(React.createElement(constructor, props), node);
2929
}
3030
};
3131

lib/react/renderer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def render(component, args={})
7070
react_props = React::Renderer.react_props(args)
7171
jscode = <<-JS
7272
function() {
73-
return React.renderComponentToString(#{component}(#{react_props}));
73+
return React.renderToString(React.createElement(#{component}, #{react_props}));
7474
}()
7575
JS
7676
context.eval(jscode).html_safe

test/react_renderer_test.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ class ReactRendererTest < ActiveSupport::TestCase
3030
err = assert_raises React::Renderer::PrerenderError do
3131
React::Renderer.render("NonexistentComponent", {error: true, exists: false})
3232
end
33-
expected_message = 'Encountered error "ReferenceError: Can\'t find variable: NonexistentComponent" when prerendering NonexistentComponent with {"error":true,"exists":false}'
34-
assert_equal expected_message, err.message
33+
expected_message_one = 'Encountered error "ReferenceError: Can\'t find variable: NonexistentComponent" when prerendering NonexistentComponent with {"error":true,"exists":false}'
34+
expected_message_two = 'Encountered error "ReferenceError: NonexistentComponent is not defined" when prerendering NonexistentComponent with {"error":true,"exists":false}'
35+
assert (expected_message_one == err.message || expected_message_two == err.message)
3536
end
3637

3738
test 'prerender errors are thrown when given a string' do
@@ -43,7 +44,8 @@ class ReactRendererTest < ActiveSupport::TestCase
4344
err = assert_raises React::Renderer::PrerenderError do
4445
React::Renderer.render("NonexistentComponent", json_string)
4546
end
46-
expected_message = 'Encountered error "ReferenceError: Can\'t find variable: NonexistentComponent" when prerendering NonexistentComponent with {"error":true,"exists":false}'
47-
assert_equal expected_message, err.message
47+
expected_message_one = 'Encountered error "ReferenceError: Can\'t find variable: NonexistentComponent" when prerendering NonexistentComponent with {"error":true,"exists":false}'
48+
expected_message_two = 'Encountered error "ReferenceError: NonexistentComponent is not defined" when prerendering NonexistentComponent with {"error":true,"exists":false}'
49+
assert (expected_message_one == err.message || expected_message_two == err.message)
4850
end
4951
end

0 commit comments

Comments
 (0)