-
Notifications
You must be signed in to change notification settings - Fork 93
Epub Highlight text empty space. #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There's a heuristic that merges highlight boxes together when they are close by. It might need to be adjusted although it depends from books to books. kotlin-toolkit/readium/navigator/src/main/assets/_scripts/src/decorator.js Lines 233 to 237 in 830812b
Could you share this book you used as an example? Note that this is not high priority, so it probably won't be fixed (by the core maintainers) soon. |
This is the one of books when i could reproduce this situtaion but like you said it probably depends from books to books because it is reproducable only on few books. |
Does anybody have any news about the status of this bug? |
I'm referencing the shared EPUB here in case it gets dropped from Google Drive: blondynka_u_szamana-gj_rba.epub.zip There is no update on this bug, and it's unlikely that we will have time to look at it anytime soon. I shared where this is happening above, if someone wants to contribute a solution. |
Bug Report
What happened?
When select more than few lines and mark it as highlight, note or underline, in the result selected area change to annotation correctly but have spaces beetwen text.
How to reproduce?
1.Open epub
2.Select more than few lines.
3.Mark as highlight, note or underline.
Environment
Android : 11
Device : One Plus 6
Readium version: develop branch - 20.01.2023, commit af2f764
The text was updated successfully, but these errors were encountered: