Skip to content

Conversation

@rafie
Copy link
Contributor

@rafie rafie commented Mar 9, 2020

bad commit: 04574d5
pre bad commit: 84ffb40

Reverted:

allow changing cursor max idle value #985:
setCursorMaxIdle()
getCursorMaxIdle()
configuration: .name = "CURSOR_MAX_IDLE"

Concurrent write mode #989:
setConcurentWriteMode()
getConcurentWriteMode()
configuration:
.name = "SAFEMODE"
.name = "CONCURRENT_WRITE_MODE"
.concurrentMode = 0

bad commit:       04574d5
pre bad commit: 84ffb40

Reverted:

allow changing cursor max idle value #985:
	setCursorMaxIdle()
	getCursorMaxIdle()
	configuration: .name = "CURSOR_MAX_IDLE"

Concurrent write mode #989:
	setConcurentWriteMode()
	getConcurentWriteMode()
	configuration:
		.name = "SAFEMODE"
		.name = "CONCURRENT_WRITE_MODE"
		.concurrentMode = 0
@rafie rafie requested a review from MeirShpilraien March 9, 2020 15:03
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #1114 into 1.6 will decrease coverage by 1.04%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.6    #1114      +/-   ##
==========================================
- Coverage   82.97%   81.92%   -1.05%     
==========================================
  Files         144      144              
  Lines       18692    18702      +10     
==========================================
- Hits        15510    15322     -188     
- Misses       3182     3380     +198     
Impacted Files Coverage Δ
src/config.h 100.00% <ø> (ø)
src/config.c 64.54% <9.09%> (-2.68%) ⬇️
src/concurrent_ctx.h 33.33% <0.00%> (-66.67%) ⬇️
src/indexer.c 51.18% <0.00%> (-41.70%) ⬇️
src/concurrent_ctx.c 32.47% <0.00%> (-38.47%) ⬇️
src/document.c 89.81% <0.00%> (-2.95%) ⬇️
src/module-init/module-init.c 71.83% <0.00%> (-1.41%) ⬇️
src/document_add.c 93.06% <0.00%> (-0.50%) ⬇️
src/doc_table.c 91.22% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a92939...ac4f4c6. Read the comment docs.

@MeirShpilraien MeirShpilraien merged commit 3e030fd into 1.6 Mar 9, 2020
@MeirShpilraien MeirShpilraien deleted the rafi-chp1 branch March 9, 2020 17:02
@emmanuelkeller emmanuelkeller added this to the 1.6.10 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants