Skip to content

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented Feb 13, 2025

Description

Manual backport of #5391 to 2.6.
(cherry picked from commit 43701d8)

Changes:

  • Since Version 2.6 limits the normalization buffer to 128 bytes, #define MAX_NORMALIZE_SIZE 128, expected results in testLongTerms() were modified to respect that limitation.

  • For tests with indexes with LANGUAGE different from ENGLISH, the LANGUAGE was added to FT.SEARCH commands because this version does not take the language from index specification

  • Since dialect 4 is not available in this version, test are only done for dialects 1 - 3.

  • In test_cpp_llapi.cpp, RediSearch_CreateTagLexRangeNode() receives only 5 arguments, in this version const char* fieldName is not part of the function signature

  • common.py:

    • Add config_cmd() and run_command_on_all_shards()
    • Replace ftDebugCmdName() by debug_cmd()

@nafraf nafraf requested review from oshadmi and raz-mon February 13, 2025 03:24
@nafraf nafraf marked this pull request as ready for review February 13, 2025 03:26
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 96.44970% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (f191462) to head (2aa21b7).
Report is 2 commits behind head on 2.6.

Files with missing lines Patch % Lines
src/query_parser/v1/lexer.c 86.95% 3 Missing ⚠️
src/query_parser/v2/parser.c 66.66% 2 Missing ⚠️
src/query_param.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #5648      +/-   ##
==========================================
+ Coverage   84.96%   85.01%   +0.04%     
==========================================
  Files         184      184              
  Lines       31343    31415      +72     
==========================================
+ Hits        26631    26706      +75     
+ Misses       4712     4709       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oshadmi oshadmi added this pull request to the merge queue Feb 18, 2025
Merged via the queue into 2.6 with commit e753767 Feb 18, 2025
11 checks passed
@oshadmi oshadmi deleted the nafraf_backport-5391-to-2.6 branch February 18, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants