Skip to content

ReactDOMServer.renderToString ... server.js not exported from react-dom #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexMoutonNoble opened this issue Aug 15, 2022 · 1 comment

Comments

@AlexMoutonNoble
Copy link

Hi Folks.
Just came across this problem in porting some existing js to rescript.
If i reimplement the renderToString bindings without the "js" suffix on the module, it seems to work fine.
Maybe a simple change to remove the suffix there?

Can make a PR if that seems reasonable

Thanks
Alex

@cknitt
Copy link
Member

cknitt commented Sep 25, 2022

Fixed in #44.

@cknitt cknitt closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants