Switch to Biome (#6838)

* switch to Biome

* do check format first

* check only changes

* ignore generated codes

* dedupe ignore list that already ignored by vcs integration

* update Biome ignore list

* did `npm run format:all` once

* use Biome for gentype tests too

* add VSCode extension recommendation

* fix more json errors

* jsx runtime should be match

Author: cometkim

.github/workflows/get_artifact_dir_name.js

@@ -6,5 +6,5 @@ const { dirName: artifactDirName } = require("../../cli/bin_path.js");
 // Pass artifactDirName to subsequent GitHub actions
 fs.appendFileSync(
   process.env.GITHUB_ENV,
-  `artifact_dir_name=${artifactDirName}${os.EOL}`
+  `artifact_dir_name=${artifactDirName}${os.EOL}`,
 );

.github/workflows/prepare_package_upload.js

@@ -9,15 +9,15 @@ const commitHashShort = commitHash.substring(0, 7);
 
 fs.renameSync(
   `rescript-${version}.tgz`,
-  `rescript-${version}-${commitHashShort}.tgz`
+  `rescript-${version}-${commitHashShort}.tgz`,
 );
 fs.renameSync(
   `packages/std/rescript-std-${version}.tgz`,
-  `rescript-std-${version}-${commitHashShort}.tgz`
+  `rescript-std-${version}-${commitHashShort}.tgz`,
 );
 
 // Pass information to subsequent GitHub actions
 fs.appendFileSync(
   process.env.GITHUB_ENV,
-  `rescript_version=${version}-${commitHashShort}${os.EOL}`
+  `rescript_version=${version}-${commitHashShort}${os.EOL}`,
 );

.gitignore

@@ -93,3 +93,6 @@ playground/*.cmj
 playground/*.cmi
 playground/.netrc
 playground/compiler.js
+
+rewatch/target/
+rewatch/rewatch

.prettierignore

@@ -0,0 +1,7 @@
+{
+  "recommendations": ["biomejs.biome", "chenglou92.rescript-vscode"],
+  "unwantedRecommendations": [
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode"
+  ]
+}

.prettierrc.json

@@ -0,0 +1,49 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "defaultBranch": "master",
+    "useIgnoreFile": true
+  },
+  "linter": {
+    "enabled": false
+  },
+  "organizeImports": {
+    "enabled": false
+  },
+  "formatter": {
+    "enabled": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 80,
+    "attributePosition": "auto",
+    "ignore": [
+      "jscomp/build_tests/**/lib/**",
+      "jscomp/build_tests/**/src/**",
+      "jscomp/test/**",
+      "lib/**",
+      "ninja/**",
+      "playground/**",
+      "**/*.bs.js",
+      "**/*.res.js",
+      "**/*.gen.ts*",
+      "package.json"
+    ]
+  },
+  "javascript": {
+    "formatter": {
+      "jsxQuoteStyle": "double",
+      "quoteProperties": "asNeeded",
+      "trailingCommas": "all",
+      "semicolons": "always",
+      "arrowParentheses": "asNeeded",
+      "bracketSpacing": true,
+      "bracketSameLine": false,
+      "quoteStyle": "double",
+      "attributePosition": "auto"
+    }
+  }
+}

.vscode/extensions.json

@@ -112,7 +112,7 @@ function parse_exn(
   annofun,
   start = 0,
   // first 3 are [node, rescript, subcommand]
-  finish = argv.length
+  finish = argv.length,
 ) {
   var current = start;
   var list = [];

biome.json

@@ -363,7 +363,7 @@ Please pick a different one using the \`-ws [host:]port\` flag from bsb.`);
   function outputError(error, highlight) {
     if (isTtyError && highlight) {
       process.stderr.write(
-        error.replace(highlight, "\x1b[1;31m" + highlight + "\x1b[0m")
+        error.replace(highlight, "\x1b[1;31m" + highlight + "\x1b[0m"),
       );
     } else {
       process.stderr.write(error);
@@ -408,7 +408,7 @@ Please pick a different one using the \`-ws [host:]port\` flag from bsb.`);
     // it could fail due to other issues like .bsb.lock
     else {
       dlog(
-        `Acquire lock failed, do the build later ${depth} : ${reasonsToRebuild}`
+        `Acquire lock failed, do the build later ${depth} : ${reasonsToRebuild}`,
       );
       const waitTime = Math.pow(2, depth) * 40;
       setTimeout(() => {

cli/rescript_arg.js

@@ -59,7 +59,7 @@ function handleOneFile(file, bsc_exe) {
         console.error(`Error when converting ${file}`);
         console.log(stderr);
       }
-    }
+    },
   );
 }
 /**
@@ -91,7 +91,7 @@ function main(argv, rescript_exe, bsc_exe) {
         ["info", "-list-files"],
         {
           encoding: "utf-8",
-        }
+        },
       );
       if (output.status !== 0) {
         console.error(output.stdout);