Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.13.1
Choose a base ref
...
head repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.13.2
Choose a head ref
  • 12 commits
  • 22 files changed
  • 2 contributors

Commits on May 12, 2013

  1. Rely on ::Rails::VERSION::STRING instead of an overly complex module

    * I did not know about ::Rails::VERSION::STRING until recently. It seems
      to be defined all the way back to 3.0.0, which is all we need.
    alindeman committed May 12, 2013
    Configuration menu
    Copy the full SHA
    4ae113b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30bbf72 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2013

  1. demonstrate issue with let

    JonRowe authored and alindeman committed May 14, 2013
    Configuration menu
    Copy the full SHA
    98c6d89 View commit details
    Browse the repository at this point in the history
  2. subject is defined as a method rather than with the subject decla…

    …rative method
    
    There is currently some odd interactions between rspec-rails and
    rspec-core when it comes to `let` definitions.
    
    If we call `subject` in an `included` hook, the dynamically generated
    `LetDefinitions` module gets inserted into the ancestor chain earlier
    than normal. This placement no longer allows `let` definitions to
    override methods defined on other modules that are brought in via
    `config.include`.
    
    We may raise a warning in future (see discussion in #738)
    
    [Fixes #738]
    
    Conflicts:
    	Changelog.md
    alindeman committed May 14, 2013
    Configuration menu
    Copy the full SHA
    e744875 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4c5c34 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2013

  1. Request specs do not live in spec/features

    [Fixes #745]
    alindeman committed May 18, 2013
    Configuration menu
    Copy the full SHA
    a7bd485 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4a3097 View commit details
    Browse the repository at this point in the history
  3. Prepares for 2.13.2

    alindeman committed May 18, 2013
    Configuration menu
    Copy the full SHA
    e224d2d View commit details
    Browse the repository at this point in the history
  4. Bumps to 2.13.2

    [ci skip]
    alindeman committed May 18, 2013
    Configuration menu
    Copy the full SHA
    d7ae7e2 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2013

  1. Configuration menu
    Copy the full SHA
    7baf241 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60f02a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55bfd60 View commit details
    Browse the repository at this point in the history
Loading