Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.2
Choose a base ref
...
head repository: rspec/rspec-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.3
Choose a head ref
  • 19 commits
  • 32 files changed
  • 6 contributors

Commits on Jan 22, 2022

  1. Add Ruby 3.1

    pirj committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    f36dda5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ac7cce View commit details
    Browse the repository at this point in the history
  3. Get RubyGems/Bundler update step back

    rubygems/bundler#6728
    
    ailure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
           expected `"Your RubyGems version (2.7.6.3)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
    pirj committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    4db28fb View commit details
    Browse the repository at this point in the history
  4. Remove Rails 7 builds

    `rspec-rails` 6.0 will support Rails 7
    pirj committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    af93525 View commit details
    Browse the repository at this point in the history
  5. Get Ruby 3.1 in CI

    petergoldstein authored and pirj committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    973e024 View commit details
    Browse the repository at this point in the history
  6. Fix arguments for have_enqueued_mail matcher

    Add additional logic to the ActionMailer argument parsing to accomodate for differences under Ruby 3.1/Rails 6.1
    
    Co-authored-by: Fabio Napoleoni <[email protected]>
    Co-authored-by: Phil Pirozhkov <[email protected]>
    3 people committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    13d8253 View commit details
    Browse the repository at this point in the history
  7. Split out Rubocop into a dedicated job and only run once

    Exclude both the "bundle" and "tmp" directory.  The former ensures we don't run rubocop against installed gems.  The latter ensures we don't run it against generated code and apps locally.
    petergoldstein authored and pirj committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    5feb2c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Changed message in have_broadcasted_to test

    Previously it was "successfully subscribes" which has very little to do with this particular test. Probably it's an artifact from copying the more general action cable tests somewhere. I found this because it shows up on documentation when googling the have_broascasted_for matcher. The message I chose is consistent with the others in this file: all existing similar tests have this message.
    Lykos authored and JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    fc038c7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2544 from muryoimpl/fix-broken-table-in-yard-doc

    Fix broken table in YARD doc
    JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    69426ef View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2534 from kenzo-tanaka/fix-scaffold-request-template

    Fix scaffold template with namespace and `--model-name` option
    JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    60b7a7e View commit details
    Browse the repository at this point in the history
  4. Changelog for #2534

    JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    7179c08 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2565 from rspec/upgrade-ffi-for-5-1

    Upgrade FFI now its safe to do so
    JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    68dc030 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2566 from rspec/ruby-31-mailer-fixes

    Improve mailer argument deserialisation for 6.1 on Ruby 3.1
    JonRowe committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    d9592f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Changelog for #2566

    JonRowe committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    69cc6c8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2520 from mirkode/main

    Add a scenario for using subdomain constrained routes
    JonRowe committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    d90f13d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db8c938 View commit details
    Browse the repository at this point in the history
  4. Synchronise with main

    JonRowe committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    23efdde View commit details
    Browse the repository at this point in the history
  5. Version 5.0.3

    JonRowe committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    3b7bd2b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3431282 View commit details
    Browse the repository at this point in the history
Loading