-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Comparing changes
Open a pull request
base repository: rspec/rspec-rails
base: v5.0.2
head repository: rspec/rspec-rails
compare: v5.0.3
- 19 commits
- 32 files changed
- 6 contributors
Commits on Jan 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f36dda5 - Browse repository at this point
Copy the full SHA f36dda5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ac7cce - Browse repository at this point
Copy the full SHA 1ac7cceView commit details -
Get RubyGems/Bundler update step back
rubygems/bundler#6728 ailure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty expected `"Your RubyGems version (2.7.6.3)) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`\n".empty?` to be truthy, got false
Configuration menu - View commit details
-
Copy full SHA for 4db28fb - Browse repository at this point
Copy the full SHA 4db28fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for af93525 - Browse repository at this point
Copy the full SHA af93525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 973e024 - Browse repository at this point
Copy the full SHA 973e024View commit details -
Fix arguments for have_enqueued_mail matcher
Add additional logic to the ActionMailer argument parsing to accomodate for differences under Ruby 3.1/Rails 6.1 Co-authored-by: Fabio Napoleoni <[email protected]> Co-authored-by: Phil Pirozhkov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 13d8253 - Browse repository at this point
Copy the full SHA 13d8253View commit details -
Split out Rubocop into a dedicated job and only run once
Exclude both the "bundle" and "tmp" directory. The former ensures we don't run rubocop against installed gems. The latter ensures we don't run it against generated code and apps locally.
Configuration menu - View commit details
-
Copy full SHA for 5feb2c7 - Browse repository at this point
Copy the full SHA 5feb2c7View commit details
Commits on Jan 25, 2022
-
Changed message in have_broadcasted_to test
Previously it was "successfully subscribes" which has very little to do with this particular test. Probably it's an artifact from copying the more general action cable tests somewhere. I found this because it shows up on documentation when googling the have_broascasted_for matcher. The message I chose is consistent with the others in this file: all existing similar tests have this message.
Configuration menu - View commit details
-
Copy full SHA for fc038c7 - Browse repository at this point
Copy the full SHA fc038c7View commit details -
Merge pull request #2544 from muryoimpl/fix-broken-table-in-yard-doc
Fix broken table in YARD doc
Configuration menu - View commit details
-
Copy full SHA for 69426ef - Browse repository at this point
Copy the full SHA 69426efView commit details -
Merge pull request #2534 from kenzo-tanaka/fix-scaffold-request-template
Fix scaffold template with namespace and `--model-name` option
Configuration menu - View commit details
-
Copy full SHA for 60b7a7e - Browse repository at this point
Copy the full SHA 60b7a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7179c08 - Browse repository at this point
Copy the full SHA 7179c08View commit details -
Merge pull request #2565 from rspec/upgrade-ffi-for-5-1
Upgrade FFI now its safe to do so
Configuration menu - View commit details
-
Copy full SHA for 68dc030 - Browse repository at this point
Copy the full SHA 68dc030View commit details -
Merge pull request #2566 from rspec/ruby-31-mailer-fixes
Improve mailer argument deserialisation for 6.1 on Ruby 3.1
Configuration menu - View commit details
-
Copy full SHA for d9592f9 - Browse repository at this point
Copy the full SHA d9592f9View commit details
Commits on Jan 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 69cc6c8 - Browse repository at this point
Copy the full SHA 69cc6c8View commit details -
Merge pull request #2520 from mirkode/main
Add a scenario for using subdomain constrained routes
Configuration menu - View commit details
-
Copy full SHA for d90f13d - Browse repository at this point
Copy the full SHA d90f13dView commit details -
Configuration menu - View commit details
-
Copy full SHA for db8c938 - Browse repository at this point
Copy the full SHA db8c938View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23efdde - Browse repository at this point
Copy the full SHA 23efddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b7bd2b - Browse repository at this point
Copy the full SHA 3b7bd2bView commit details -
Remove changes from main that were not supposed to be included
This reverts commit 6eb0459.
Configuration menu - View commit details
-
Copy full SHA for 3431282 - Browse repository at this point
Copy the full SHA 3431282View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.0.2...v5.0.3