Merge ref 'ce63e5d9ea20' from rust-lang/rust

Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: ce63e5d9ea20f15a70c6fdc4d4de7aee352fd965
Filtered ref: 3be97ed
Upstream diff: rust-lang/rust@dfe1b8c...ce63e5d

This merge was created using https://github.com/rust-lang/josh-sync.

Author: The rustc-josh-sync Cronjob Bot

src/bug-fix-procedure.md

@@ -91,40 +91,46 @@ future-compatibility warnings. These are a special category of lint warning.
 Adding a new future-compatibility warning can be done as follows.
 
 ```rust
-// 1. Define the lint in `compiler/rustc_middle/src/lint/builtin.rs`:
+// 1. Define the lint in `compiler/rustc_lint/src/builtin.rs` and 
+//    add the metadata for the future incompatibility:
 declare_lint! {
-    pub YOUR_ERROR_HERE,
+    pub YOUR_LINT_HERE,
     Warn,
     "illegal use of foo bar baz"
+    @future_incompatible = FutureIncompatibleInfo {
+        reason: fcw!(FutureReleaseError #1234) // your tracking issue here!
+    },
 }
 
-// 2. Add to the list of HardwiredLints in the same file:
-impl LintPass for HardwiredLints {
-    fn get_lints(&self) -> LintArray {
-        lint_array!(
-            ..,
-            YOUR_ERROR_HERE
-        )
-    }
+// 2. Add a decidacted lint pass for it.
+//    This step can be skipped if you emit the lint as part of an existing pass.
+
+#[derive(Default)]
+pub struct MyLintPass {
+    ...
 }
 
-// 3. Register the lint in `compiler/rustc_lint/src/lib.rs`:
-store.register_future_incompatible(sess, vec![
-    ...,
-    FutureIncompatibleInfo {
-        id: LintId::of(YOUR_ERROR_HERE),
-        reference: "issue #1234", // your tracking issue here!
+impl {Early,Late}LintPass for MyLintPass { 
+    ...
+}
+
+impl_lint_pass!(MyLintPass => [YOUR_LINT_HERE]);
+
+// 3. emit the lint somewhere in your lint pass:
+cx.emit_span_lint(
+    YOUR_LINT_HERE,
+    pat.span,
+    // some diagnostic struct
+    MyDiagnostic {
+        ...
     },
-]);
-
-// 4. Report the lint:
-tcx.lint_node(
-    lint::builtin::YOUR_ERROR_HERE,
-    path_id,
-    binding.span,
-    format!("some helper message here"));
+);
+
 ```
 
+Finally, register the lint in `compiler/rustc_lint/src/lib.rs`. 
+There are many examples in that file that already show how to do so.
+
 #### Helpful techniques
 
 It can often be challenging to filter out new warnings from older, pre-existing
@@ -221,7 +227,10 @@ The first reference you will likely find is the lint definition [in
 declare_lint! {
     pub OVERLAPPING_INHERENT_IMPLS,
     Deny, // this may also say Warning
-    "two overlapping inherent impls define an item with the same name were erroneously allowed"
+    "two overlapping inherent impls define an item with the same name were erroneously allowed",
+    @future_incompatible = FutureIncompatibleInfo {
+        reason: fcw!(FutureReleaseError #1234), // your tracking issue here!
+    },
 }
 ```
 
@@ -231,19 +240,6 @@ the file as [part of a `lint_array!`][lintarraysource]; remove it too.
 
 [lintarraysource]: https://github.com/rust-lang/rust/blob/085d71c3efe453863739c1fb68fd9bd1beff214f/src/librustc/lint/builtin.rs#L252-L290
 
-Next, you see [a reference to `OVERLAPPING_INHERENT_IMPLS` in
-`rustc_lint/src/lib.rs`][futuresource]. This is defining the lint as a "future
-compatibility lint":
-
-```rust
-FutureIncompatibleInfo {
-    id: LintId::of(OVERLAPPING_INHERENT_IMPLS),
-    reference: "issue #36889 <https://github.com/rust-lang/rust/issues/36889>",
-},
-```
-
-Remove this too.
-
 #### Add the lint to the list of removed lints.
 
 In `compiler/rustc_lint/src/lib.rs` there is a list of "renamed and removed lints".
@@ -269,6 +265,8 @@ self.tcx.sess.add_lint(lint::builtin::OVERLAPPING_INHERENT_IMPLS,
                        msg);
 ```
 
+You'll also often find `node_span_lint` used for this.
+
 We want to convert this into an error. In some cases, there may be an
 existing error for this scenario. In others, we will need to allocate a
 fresh diagnostic code.  [Instructions for allocating a fresh diagnostic
@@ -285,6 +283,17 @@ struct_span_code_err!(self.dcx(), self.tcx.span_of_impl(item1).unwrap(), E0592,
     .emit();
 ```
 
+Or better: a structured diagnostic like this:
+
+```rust
+#[derive(Diagnostic)]
+struct MyDiagnostic {
+    #[label]
+    span: Span,
+    ...
+}
+```
+
 #### Update tests
 
 Finally, run the test suite. These should be some tests that used to reference

src/diagnostics.md

@@ -732,8 +732,7 @@ declare_lint! {
     Allow,
     "detects anonymous parameters",
     @future_incompatible = FutureIncompatibleInfo {
-        reference: "issue #41686 <https://github.com/rust-lang/rust/issues/41686>",
-        reason: FutureIncompatibilityReason::EditionError(Edition::Edition2018),
+        reason: fcw!(EditionError 2018 "slug-of-edition-guide-page")
     };
 }
 ```

src/guides/editions.md

@@ -179,8 +179,7 @@ declare_lint! {
     Allow,
     "detects edition keywords being used as an identifier",
     @future_incompatible = FutureIncompatibleInfo {
-        reason: FutureIncompatibilityReason::EditionError(Edition::Edition2018),
-        reference: "issue #49716 <https://github.com/rust-lang/rust/issues/49716>",
+        reason: fcw!(EditionError 2018 "slug-of-edition-guide-page")
     };
 }
 ```