feat: extract the delimiter to a const value for uniformity

Author: madhav-madhusoodanan

crates/intrinsic-test/src/common/compare.rs

@@ -2,6 +2,7 @@ use itertools::Itertools;
 use rayon::prelude::*;
 use std::{collections::HashMap, process::Command};
 
+pub const INTRINSIC_DELIMITER: &str = "############";
 fn runner_command(runner: &str) -> Command {
     let mut it = runner.split_whitespace();
     let mut cmd = Command::new(it.next().unwrap());
@@ -27,7 +28,7 @@ pub fn compare_outputs(intrinsic_name_list: &Vec<String>, runner: &str, target:
     );
     let (c, rust) = match (c, rust) {
         (Ok(c), Ok(rust)) => (c, rust),
-        a => panic!("{a:#?}"),
+        failure => panic!("Failed to run: {failure:#?}"),
     };
 
     if !c.status.success() {
@@ -56,11 +57,11 @@ pub fn compare_outputs(intrinsic_name_list: &Vec<String>, runner: &str, target:
         .replace("-nan", "nan");
 
     let c_output_map = c
-        .split("############")
+        .split(INTRINSIC_DELIMITER)
         .filter_map(|output| output.trim().split_once("\n"))
         .collect::<HashMap<&str, &str>>();
     let rust_output_map = rust
-        .split("############")
+        .split(INTRINSIC_DELIMITER)
         .filter_map(|output| output.trim().split_once("\n"))
         .collect::<HashMap<&str, &str>>();
 
@@ -74,7 +75,7 @@ pub fn compare_outputs(intrinsic_name_list: &Vec<String>, runner: &str, target:
         .filter_map(|&&intrinsic| {
             let c_output = c_output_map.get(intrinsic).unwrap();
             let rust_output = rust_output_map.get(intrinsic).unwrap();
-            if rust_output.to_string() == c_output.to_string() {
+            if rust_output.eq(c_output) {
                 None
             } else {
                 let diff = diff::lines(c_output, rust_output);

crates/intrinsic-test/src/common/gen_c.rs

@@ -1,6 +1,7 @@
 use crate::common::intrinsic::Intrinsic;
 
 use super::argument::Argument;
+use super::compare::INTRINSIC_DELIMITER;
 use super::indentation::Indentation;
 use super::intrinsic_helpers::IntrinsicTypeDefinition;
 
@@ -149,7 +150,10 @@ pub fn write_main_cpp<'a>(
     writeln!(w, "int main(int argc, char **argv) {{")?;
 
     for intrinsic in intrinsics {
-        writeln!(w, "    std::cout << \"############\" << std::endl;")?;
+        writeln!(
+            w,
+            "    std::cout << \"{INTRINSIC_DELIMITER}\" << std::endl;"
+        )?;
         writeln!(w, "    std::cout << \"{intrinsic}\" << std::endl;")?;
         writeln!(w, "    run_{intrinsic}();\n")?;
     }

crates/intrinsic-test/src/common/gen_rust.rs

@@ -1,11 +1,11 @@
 use itertools::Itertools;
 use std::process::Command;
 
-use crate::common::argument::ArgumentList;
-use crate::common::intrinsic::Intrinsic;
-
+use super::compare::INTRINSIC_DELIMITER;
 use super::indentation::Indentation;
 use super::intrinsic_helpers::IntrinsicTypeDefinition;
+use crate::common::argument::ArgumentList;
+use crate::common::intrinsic::Intrinsic;
 
 // The number of times each intrinsic will be called.
 pub(crate) const PASSES: u32 = 20;
@@ -87,7 +87,7 @@ pub fn write_main_rs<'a>(
     writeln!(w, "fn main() {{")?;
 
     for binary in intrinsics {
-        writeln!(w, "    println!(\"############\");")?;
+        writeln!(w, "    println!(\"{INTRINSIC_DELIMITER}\");")?;
         writeln!(w, "    println!(\"{binary}\");")?;
         writeln!(w, "    run_{binary}();\n")?;
     }