Web Inspector: should not include implementation details of the injected script in stack traces

https://bugs.webkit.org/show_bug.cgi?id=242954

Reviewed by Yusuke Suzuki.

* Source/JavaScriptCore/runtime/ImplementationVisibility.h:
Add a new `PrivateRecursive` that tells JSC to also propagate it to any nested functions.

* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generator.py:
(BuiltinsGenerator.generate_embedded_code_data_for_function):
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_model.py:
(BuiltinFunction.__init__):
(BuiltinFunction.fromString):
Allow builtins to define a custom `@visibility=...`. If not defined, `@linkTimeConstant` is
`Private` and everything else is `Public`.

* Source/JavaScriptCore/inspector/InjectedScriptSource.js:
Annotate `createInspectorInjectedScript` with `@visibility=PrivateRecursive`.

* Source/JavaScriptCore/parser/Nodes.h:
* Source/JavaScriptCore/parser/Nodes.cpp:
(JSC::FunctionMetadataNode::FunctionMetadataNode):
(JSC::FunctionMetadataNode::operator== const):
(JSC::FunctionMetadataNode::dump const):
* Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:
(JSC::UnlinkedFunctionExecutable::create):
* Source/JavaScriptCore/builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
* Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewClassFieldInitializerFunction):
Have the `FunctionMetadataNode` hold the `ImplementationVisibility` instead of directly giving it to
the `UnlinkedFunctionExecutable`, as the `FunctionMetadataNode` has more widespread usage.

* Source/JavaScriptCore/parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionMetadata):
* Source/JavaScriptCore/parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::implementationVisibility const): Added.
(JSC::Parser::pushScope):
(JSC::Parser::resetImplementationVisibilityIfNeeded): Added.
(JSC::Parser::implementationVisibility): Added.
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):
* Source/JavaScriptCore/parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo):
* Source/JavaScriptCore/parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionMetadata):
Pass along the `ImplementationVisibility` to the creation of the `FunctionMetadataNode` when parsing.
Make sure the `ImplementationVisibility` is properly propagated when new `Scope` are created.

* Source/JavaScriptCore/debugger/DebuggerParseData.cpp:
(JSC::gatherDebuggerParseData):
* Source/JavaScriptCore/runtime/CodeCache.cpp:
(JSC::generateUnlinkedCodeBlockImpl):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
* Source/JavaScriptCore/runtime/Completion.cpp:
(JSC::checkSyntaxInternal):
(JSC::checkModuleSyntax):
* Source/JavaScriptCore/API/JSScriptRef.cpp:
(parseScript):
* Source/JavaScriptCore/API/glib/JSCContext.cpp:
(jsc_context_check_syntax):
* Source/JavaScriptCore/runtime/JSModuleLoader.cpp:
(JSC::moduleLoaderParseModule):
Non-builtins should be `ImplementationVisibility::Public`.

* Source/JavaScriptCore/parser/ParserModes.h:
Decrease the width of `LexicalScopeFeatures` to make room for the wider `ImplementationVisibility`.

* Source/JavaScriptCore/runtime/FunctionPrototype.cpp:
(JSC::isAllowedReceiverFunctionForCallerAndArguments):
(JSC::RetrieveCallerFunctionFunctor::operator() const):
Ignore anything that isn't `ImplementationVisibility::Public`.

* LayoutTests/inspector/animation/lifecycle-web-animation-expected.txt:
* LayoutTests/inspector/canvas/create-context-2d-expected.txt:
* LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt:
* LayoutTests/inspector/canvas/create-context-webgl-expected.txt:
* LayoutTests/inspector/canvas/create-context-webgl2-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-full-expected.txt:
* LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-full-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-frameCount-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-full-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-memoryLimit-expected.txt:
* LayoutTests/inspector/canvas/recording-webgl2-snapshots-expected.txt:
* LayoutTests/inspector/model/remote-object/error-expected.txt:
* LayoutTests/inspector/model/stack-trace-expected.txt:
* LayoutTests/inspector/timeline/line-column-expected.txt:
* LayoutTests/platform/gtk/inspector/timeline/line-column-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-frameCount-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-memoryLimit-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-frameCount-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-memoryLimit-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt:

Canonical link: https://commits.webkit.org/252914@main

Author: dcrousso

LayoutTests/inspector/animation/lifecycle-web-animation-expected.txt

@@ -14,8 +14,6 @@ PASS: Animation created 'web-animation-test'.
   1: createAnimation - inspector/animation/resources/lifecycle-utilities.js:3:15
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 PASS: Animation type should be Web Animation.
 startDelay: 100
 endDelay: 200

LayoutTests/inspector/canvas/create-context-2d-expected.txt

@@ -11,8 +11,6 @@ PASS: Canvas context should be 2D.
   1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -22,8 +20,6 @@ PASS: Canvas context should be 2D.
   1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -34,8 +30,6 @@ PASS: Canvas context should be 2D.
   1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Canvas name should equal the identifier passed to -webkit-canvas.
 

LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt

@@ -11,8 +11,6 @@ PASS: Canvas context should be Bitmap Renderer.
   1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -22,8 +20,6 @@ PASS: Canvas context should be Bitmap Renderer.
   1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 

LayoutTests/inspector/canvas/create-context-webgl-expected.txt

@@ -11,8 +11,6 @@ PASS: Canvas context should be WebGL.
   1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -22,8 +20,6 @@ PASS: Canvas context should be WebGL.
   1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -34,8 +30,6 @@ PASS: Canvas context should be WebGL.
   1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Canvas name should equal the identifier passed to -webkit-canvas.
 

LayoutTests/inspector/canvas/create-context-webgl2-expected.txt

@@ -11,8 +11,6 @@ PASS: Canvas context should be WebGL2.
   1: createAttachedCanvas - inspector/canvas/resources/create-context-utilities.js:4:36
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -22,8 +20,6 @@ PASS: Canvas context should be WebGL2.
   1: createDetachedCanvas - inspector/canvas/resources/create-context-utilities.js:11:62
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Removed canvas has expected ID.
 
@@ -34,8 +30,6 @@ PASS: Canvas context should be WebGL2.
   1: createCSSCanvas - inspector/canvas/resources/create-context-utilities.js:18:47
   2: Global Code - [program code]
   3: evaluateWithScopeExtension - [native code]
-  4: (anonymous function) - [native code]
-  5: _wrapCall - [native code]
 
 PASS: Canvas name should equal the identifier passed to -webkit-canvas.
 

LayoutTests/inspector/canvas/recording-2d-frameCount-expected.txt

@@ -46,8 +46,6 @@ frames:
         5: performActions
         6: Global Code
         7: evaluateWithScopeExtension
-        8: (anonymous function)
-        9: _wrapCall
     1: arc(6, 7, 8, 9, 10, true)
       swizzleTypes: [Number, Number, Number, Number, Number, Boolean]
       trace:
@@ -59,6 +57,4 @@ frames:
         5: performActions
         6: Global Code
         7: evaluateWithScopeExtension
-        8: (anonymous function)
-        9: _wrapCall
 

LayoutTests/inspector/canvas/recording-2d-full-expected.txt

@@ -46,8 +46,6 @@ frames:
         5: performActions
         6: Global Code
         7: evaluateWithScopeExtension
-        8: (anonymous function)
-        9: _wrapCall
     1: arc(6, 7, 8, 9, 10, true)
       swizzleTypes: [Number, Number, Number, Number, Number, Boolean]
       trace:
@@ -59,8 +57,6 @@ frames:
         5: performActions
         6: Global Code
         7: evaluateWithScopeExtension
-        8: (anonymous function)
-        9: _wrapCall
   1: (duration)
     0: arcTo(1, 2, 3, 4, 5)
       swizzleTypes: [Number, Number, Number, Number, Number]

LayoutTests/inspector/canvas/recording-2d-memoryLimit-expected.txt

@@ -46,6 +46,4 @@ frames:
         5: performActions
         6: Global Code
         7: evaluateWithScopeExtension
-        8: (anonymous function)
-        9: _wrapCall
 

LayoutTests/inspector/canvas/recording-webgl-frameCount-expected.txt

@@ -21,6 +21,4 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall
 

LayoutTests/inspector/canvas/recording-webgl-full-expected.txt

@@ -21,8 +21,6 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall
   1: (duration)
     0: attachShader(0, 0)
       swizzleTypes: [WebGLProgram, WebGLShader]

LayoutTests/inspector/canvas/recording-webgl-memoryLimit-expected.txt

@@ -21,6 +21,4 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall
 

LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt

@@ -19,8 +19,6 @@ frames:
         1: performActions
         2: Global Code
         3: evaluateWithScopeExtension
-        4: (anonymous function)
-        5: _wrapCall
     1: clearColor(0, 0, 0, 1)
       swizzleTypes: [Number, Number, Number, Number]
       trace:
@@ -29,8 +27,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     2: clear(16384)
       swizzleTypes: [Number]
       trace:
@@ -39,8 +35,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
       snapshot: <PASS: content changed>
     3: bufferData(34962, 0, 35044)
       swizzleTypes: [Number, TypedArray, Number]
@@ -50,8 +44,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     4: drawArrays(4, 0, 3)
       swizzleTypes: [Number, Number, Number]
       trace:
@@ -60,8 +52,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
       snapshot: <PASS: content changed>
     5: clearColor(0, 0, 0, 1)
       swizzleTypes: [Number, Number, Number, Number]
@@ -71,8 +61,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     6: clear(16384)
       swizzleTypes: [Number]
       trace:
@@ -81,8 +69,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
       snapshot: <PASS: content changed>
     7: bufferData(34962, 0, 35044)
       swizzleTypes: [Number, TypedArray, Number]
@@ -92,8 +78,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     8: bufferData(34963, 0, 35044)
       swizzleTypes: [Number, TypedArray, Number]
       trace:
@@ -102,8 +86,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     9: drawElements(4, 3, 5123, 0)
       swizzleTypes: [Number, Number, Number, Number]
       trace:
@@ -112,8 +94,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
       snapshot: <PASS: content changed>
     10: clearColor(0, 0, 0, 1)
       swizzleTypes: [Number, Number, Number, Number]
@@ -123,8 +103,6 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
     11: clear(16384)
       swizzleTypes: [Number]
       trace:
@@ -133,7 +111,5 @@ frames:
         2: performActions
         3: Global Code
         4: evaluateWithScopeExtension
-        5: (anonymous function)
-        6: _wrapCall
       snapshot: <PASS: content changed>
 

LayoutTests/inspector/canvas/recording-webgl2-frameCount-expected.txt

@@ -21,6 +21,4 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall
 

LayoutTests/inspector/canvas/recording-webgl2-full-expected.txt

@@ -21,8 +21,6 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall
   1: (duration)
     0: attachShader(0, 0)
       swizzleTypes: [WebGLProgram, WebGLShader]

LayoutTests/inspector/canvas/recording-webgl2-memoryLimit-expected.txt

@@ -21,6 +21,4 @@ frames:
         3: performActions
         4: Global Code
         5: evaluateWithScopeExtension
-        6: (anonymous function)
-        7: _wrapCall