Skip to content

Commit b9026fd

Browse files
committed
Merge pull request cpp-netlib#370 from ruslo/remove.dependencies
Remove unnecessary 'add_dependencies' commands
2 parents 27de355 + af29642 commit b9026fd

File tree

4 files changed

+0
-25
lines changed

4 files changed

+0
-25
lines changed

http/src/CMakeLists.txt

-16
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ set(CPP-NETLIB_HTTP_MESSAGE_SRCS
2525

2626
if(NOT CPP-NETLIB_BUILD_SINGLE_LIB)
2727
add_library(cppnetlib-http-message ${CPP-NETLIB_HTTP_MESSAGE_SRCS})
28-
add_dependencies(cppnetlib-http-message
29-
cppnetlib-message)
3028
target_link_libraries(cppnetlib-http-message
3129
${Boost_LIBRARIES}
3230
cppnetlib-message)
@@ -77,17 +75,6 @@ endif()
7775
#
7876
#if(NOT CPP-NETLIB_BUILD_SINGLE_LIB)
7977
# add_library(cppnetlib-http-client ${CPP-NETLIB_HTTP_CLIENT_SRCS})
80-
# add_dependencies(cppnetlib-http-client
81-
# ${CPP-NETLIB_LOGGING_LIB}
82-
# cppnetlib-constants
83-
# cppnetlib-uri
84-
# cppnetlib-message
85-
# cppnetlib-message-wrappers
86-
# cppnetlib-message-directives
87-
# cppnetlib-http-message
88-
# cppnetlib-http-message-wrappers
89-
# cppnetlib-http-client-connections
90-
# )
9178
# target_link_libraries(cppnetlib-http-client
9279
# ${Boost_LIBRARIES}
9380
# ${CPP-NETLIB_LOGGING_LIB}
@@ -108,9 +95,6 @@ set(CPP-NETLIB_HTTP_V2_CLIENT_SRCS
10895
${CMAKE_CURRENT_SOURCE_DIR}/http/v2/client/client_errors.cpp
10996
)
11097
add_library(network-http-v2-client ${CPP-NETLIB_HTTP_V2_CLIENT_SRCS})
111-
add_dependencies(network-http-v2-client
112-
network-uri
113-
)
11498
target_link_libraries(network-http-v2-client
11599
${Boost_LIBRARIES}
116100
network-uri

logging/test/CMakeLists.txt

-3
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,15 @@ if (CPP-NETLIB_BUILD_TESTS)
1717
)
1818
if(CPP-NETLIB_BUILD_SINGLE_LIB)
1919
set(link_cppnetlib_lib cppnetlib)
20-
set(dependency cppnetlib)
2120
else()
2221
set(link_cppnetlib_lib cppnetlib-logging)
23-
set(dependency cppnetlib-logging)
2422
endif()
2523
foreach (test ${TESTS})
2624
if (${CMAKE_CXX_COMPILER_ID} MATCHES GNU)
2725
set_source_files_properties(${test}.cpp
2826
PROPERTIES COMPILE_FLAGS "-Wall")
2927
endif()
3028
add_executable(cpp-netlib-${test} ${test}.cpp)
31-
add_dependencies(cpp-netlib-${test} ${dependency})
3229
target_link_libraries(cpp-netlib-${test}
3330
${Boost_LIBRARIES} ${GTEST_BOTH_LIBRARIES} ${link_cppnetlib_lib})
3431
set_target_properties(cpp-netlib-${test}

message/src/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ set(CPP-NETLIB_MESSAGE_SRCS
1111
message.cpp)
1212

1313
add_library(cppnetlib-message ${CPP-NETLIB_MESSAGE_SRCS})
14-
add_dependencies(cppnetlib-message network-uri)
1514
target_link_libraries(cppnetlib-message network-uri)
1615

1716
set(CPP-NETLIB_MESSAGE_DIRECTIVES_SRCS

message/test/CMakeLists.txt

-5
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,13 @@ if (CPP-NETLIB_BUILD_TESTS)
1111
set(TESTS message_test message_transform_test)
1212
if(CPP-NETLIB_BUILD_SINGLE_LIB)
1313
set(link_cppnetlib_lib cppnetlib)
14-
set(dependencies cppnetlib)
1514
else()
1615
set(link_cppnetlib_lib cppnetlib-message
1716
cppnetlib-message-directives
1817
cppnetlib-message-wrappers)
19-
set(dependencies cppnetlib-message
20-
cppnetlib-message-directives
21-
cppnetlib-message-wrappers)
2218
endif()
2319
foreach (test ${TESTS})
2420
add_executable(cpp-netlib-${test} ${test}.cpp)
25-
add_dependencies(cpp-netlib-${test} ${dependencies})
2621
target_link_libraries(cpp-netlib-${test}
2722
${Boost_SYSTEM_LIBRARY}
2823
${CMAKE_THREAD_LIBS_INIT}

0 commit comments

Comments
 (0)