Skip to content

Typo in pin assignment configuration for 4PWM #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 23, 2022

Conversation

arturohernandez10
Copy link
Contributor

I made this small correction in multiple files. Once I did my project seem to work better. I still need some hardware. Without knowing the inner workings of the project. It does look like a simple typo that got copied over multiple files.

 GenericDriverParams* params = new GenericDriverParams {
-    .pins = { pin1A, pin2A, pin2A, pin2B },
+    .pins = { pin1A, pin1B, pin2A, pin2B },
    .pwm_frequency = pwm_frequency
  };

@Ceypher
Copy link

Ceypher commented May 23, 2022

I confirm on my side, using Arduino nano, this bug fix worked fine

@runger1101001 runger1101001 changed the base branch from master to dev May 23, 2022 08:29
@runger1101001
Copy link
Member

I will merge this. It includes some things that were committed against the master branch only, but these should probably be merged to dev anyway.

@runger1101001 runger1101001 merged commit 7e65e51 into simplefoc:dev May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants