sqlite / sqlcipher API inconsistency

[alipov]

Hi,

Is there a reason why SQLiteStatement#executeUpdateDelete() 's return type is long, instead of int (as specified in Android's API)?

The value in any case comes from mDatabase.lastChangeCount(), which is int by itself, so I don't understand why to change the type. Could you please elaborate?

Thanks!
Alex.

[developernotes]

Hello @alipov

Thank you for the inquiry, as it turns out, the call to lastChangeCount() internally calls SQLite sqlite3_changes which returns an int. This is likely a historical mistake, we will correct the return signature. Thanks!

[alipov]

Hi @developernotes

Half year passed and this issue not yet fixed.
Would you like me to open a pull request?

Alex.

[developernotes]

Hello @alipov

Thank you for the reminder, I have made the change in the following commit.

[alipov]

Great, thanks!