Lint Fixes

Author: smarek

library/src/main/java/com/loopj/android/http/Base64OutputStream.java

@@ -27,7 +27,7 @@ public class Base64OutputStream extends FilterOutputStream {
     private byte[] buffer = null;
     private int bpos = 0;
 
-    private static byte[] EMPTY = new byte[0];
+    private static final byte[] EMPTY = new byte[0];
 
     /**
      * Performs Base64 encoding on the data written to the stream, writing the encoded data to

library/src/main/java/com/loopj/android/http/MySSLSocketFactory.java

@@ -56,7 +56,7 @@
  * certificate validation on every device, use with caution
  */
 public class MySSLSocketFactory extends SSLSocketFactory {
-    SSLContext sslContext = SSLContext.getInstance("TLS");
+    final SSLContext sslContext = SSLContext.getInstance("TLS");
 
     /**
      * Creates a new SSL Socket Factory with the given KeyStore.

library/src/main/java/com/loopj/android/http/SimpleMultipartEntity.java

@@ -38,7 +38,7 @@
 import java.io.OutputStream;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Random;
+import java.security.SecureRandom;
 
 /**
  * Simplified multipart entity mainly used for sending one or more files.
@@ -74,7 +74,7 @@ class SimpleMultipartEntity implements HttpEntity {
 
     public SimpleMultipartEntity(ResponseHandlerInterface progressHandler) {
         final StringBuilder buf = new StringBuilder();
-        final Random rand = new Random();
+        final SecureRandom rand = new SecureRandom();
         for (int i = 0; i < 30; i++) {
             buf.append(MULTIPART_CHARS[rand.nextInt(MULTIPART_CHARS.length)]);
         }
@@ -171,8 +171,8 @@ private void updateProgress(long count) {
     }
 
     private class FilePart {
-        public File file;
-        public byte[] header;
+        public final File file;
+        public final byte[] header;
 
         public FilePart(String key, File file, String type, String customFileName) {
             header = createHeader(key, TextUtils.isEmpty(customFileName) ? file.getName() : customFileName, type);

sample/src/main/java/com/loopj/android/http/sample/AsyncBackgroundThreadSample.java

@@ -40,7 +40,7 @@
 public class AsyncBackgroundThreadSample extends SampleParentActivity {
     private static final String LOG_TAG = "AsyncBackgroundThreadSample";
 
-    private ExecutorService executor = Executors.newSingleThreadExecutor();
+    private final ExecutorService executor = Executors.newSingleThreadExecutor();
 
     @Override
     public void onStop()

sample/src/main/java/com/loopj/android/http/sample/SampleParentActivity.java

@@ -225,7 +225,7 @@ public void onCancelButtonPressed() {
         asyncHttpClient.cancelRequests(SampleParentActivity.this, true);
     }
 
-    protected View.OnClickListener onClickListener = new View.OnClickListener() {
+    protected final View.OnClickListener onClickListener = new View.OnClickListener() {
         @Override
         public void onClick(View v) {
             switch (v.getId()) {

sample/src/main/java/com/loopj/android/http/sample/SaxSample.java

@@ -40,7 +40,7 @@ public ResponseHandlerInterface getResponseHandler() {
         return saxAsyncHttpResponseHandler;
     }
 
-    private SaxAsyncHttpResponseHandler saxAsyncHttpResponseHandler = new SaxAsyncHttpResponseHandler<SAXTreeStructure>(new SAXTreeStructure()) {
+    private final SaxAsyncHttpResponseHandler saxAsyncHttpResponseHandler = new SaxAsyncHttpResponseHandler<SAXTreeStructure>(new SAXTreeStructure()) {
         @Override
         public void onStart() {
             clearOutputs();
@@ -93,8 +93,8 @@ public RequestHandle executeSample(AsyncHttpClient client, String URL, Header[]
     }
 
     private class Tuple {
-        public Integer color;
-        public String text;
+        public final Integer color;
+        public final String text;
 
         public Tuple(int _color, String _text) {
             this.color = _color;
@@ -104,7 +104,7 @@ public Tuple(int _color, String _text) {
 
     private class SAXTreeStructure extends DefaultHandler {
 
-        public List<Tuple> responseViews = new ArrayList<Tuple>();
+        public final List<Tuple> responseViews = new ArrayList<Tuple>();
 
         public void startElement(String namespaceURI, String localName,
                                  String rawName, Attributes atts) {

sample/src/main/java/com/loopj/android/http/sample/services/ExampleIntentService.java

@@ -21,7 +21,7 @@ public class ExampleIntentService extends IntentService {
     public static final String INTENT_DATA = "INTENT_DATA";
     public static final String INTENT_THROWABLE = "INTENT_THROWABLE";
 
-    private AsyncHttpClient aClient = new SyncHttpClient();
+    private final AsyncHttpClient aClient = new SyncHttpClient();
 
     public ExampleIntentService() {
         super("ExampleIntentService");