Skip to content

Incorrect search result links #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eltigerchino opened this issue Mar 11, 2025 · 1 comment
Open

Incorrect search result links #1184

eltigerchino opened this issue Mar 11, 2025 · 1 comment

Comments

@eltigerchino
Copy link
Member

eltigerchino commented Mar 11, 2025

When searching for "svelte:component" such as https://svelte.dev/search?q=svelte%3Acomponent , the links to the Misc page incorrectly link to https://svelte.dev/docs/svelte/v5-migration-guide#is-no-longer-necessary when it should be https://svelte.dev/docs/svelte/v5-migration-guide#svelte:component-is-no-longer-necessary . Notably, the anchor has omitted "svelte:component" from the link.

- https://svelte.dev/docs/svelte/v5-migration-guide#is-no-longer-necessary
+ https://svelte.dev/docs/svelte/v5-migration-guide#svelte:component-is-no-longer-necessary
@zqianem
Copy link
Contributor

zqianem commented May 19, 2025

Didn't quite get to how to fix this, but the root cause is that slugify is being called on input like `<svelte:component>` is no longer necessary in https://github.com/sveltejs/svelte.dev/blob/main/apps/svelte.dev/src/routes/content.json/%2Bserver.ts when really, it was designed to be called on input like <code>&lt;svelte:component&gt;</code> is no longer necessary, such as when the actual hrefs are generated in https://github.com/sveltejs/svelte.dev/blob/main/packages/site-kit/src/lib/markdown/renderer.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants