Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.0
Choose a base ref
...
head repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.0
Choose a head ref
  • 17 commits
  • 14 files changed
  • 3 contributors

Commits on Oct 4, 2023

  1. Add docker-compose file for 5.10 CI (#19)

    ### Motivation
    
    Now Swift 5.9 is released and 5.10 nightly images are available, we
    should update our CI to use the official release for 5.10 and setup a
    new CI for 5.10.
     
    ### Modifications
    
    - Update 5.9 CI to use `swift:5.9-jammy`
    - Add new CI for `swiftlang/swift:nightly-5.10-jammy`
    
    ### Result
    
    - 5.9 CI is using official released image.
    - 5.10 CI can be brought online.
    
    ### Test Plan
    
    Running both of these commands locally succeed:
    
    ```console
    % docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.2204.59.yaml run test
    ```
    ```console
    % docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.2204.510.yaml run test
    ```
    simonjbeaumont authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6779786 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    f3fa4a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Bump swift-format to 5.9 (#20)

    Bump swift-format to 5.9
    
    ### Motivation
    
    As per apple/swift-openapi-generator#175.
    
    ### Modifications
    
    Bump swift-format, update to make soundness pass.
    
    ### Result
    
    Using swift-format 5.9.
    
    ### Test Plan
    
    Soundness passed.
    
    
    Reviewed by: dnadoba
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.8) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #20
    czechboy0 authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2e72905 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Add a soundness --fix flag (#22)

    Add a soundness --fix flag
    
    ### Motivation
    
    When running `./scripts/soundness.sh` produces swift-format warnings, we ask adopters to manually copy/paste a call to swift format to fix the warnings up. This is tedious and unnecessary.
    
    ### Modifications
    
    Add a `--fix` option on the `soundness.sh` script to actually apply the fixes as well, avoiding the need to copy/paste long commands.
    
    ### Result
    
    Easier fixing up of formatting warnings.
    
    ### Test Plan
    
    Manually tested the workflow locally.
    
    
    Reviewed by: glbrntt
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.8) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #22
    czechboy0 authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7c6a9e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Disable "respectsExistingLineBreaks" in .swift-format for more consis…

    …tent styling (#23)
    
    ### Motivation
    
    - Relates to
    [#230](apple/swift-openapi-generator#230)
    
    ### Modifications
    
    - Disable respectsExistingLineBreaks .swift-format rule and address
    changes requested
    
    ### Result
    
    - One of the .swift-format rules will be disabled
    
    ### Test Plan
    
    - Run Tests
    PARAIPAN9 authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e48b152 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Add README badges (#24)

    ### Motivation
    
    Surface the Swift version and platform support status from Swift Package
    Index.
    
    ### Modifications
    
    Added badges, plus a quick link to the docc docs, to the top of the
    README.
    
    Also, expanded the supported platforms, we do actually support iOS and
    friends (was an oversight not to include it before).
    
    ### Result
    
    Easier to quickly see our support matrix, plus the quick link to docs.
    
    ### Test Plan
    
    Previewed locally.
    czechboy0 authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    701d752 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Prep for 1.0 alpha, adapted to runtime changes in main (#25)

    ### Motivation
    
    On main, the HTTPBody length type changed from Int to Int64.
    
    ### Modifications
    
    Adapted the transport with this change.
    
    ### Result
    
    Repo builds again when using the latest runtime.
    
    ### Test Plan
    
    Adapted tests.
    czechboy0 authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    caa5303 View commit details
    Browse the repository at this point in the history
  2. Move to Swift 5.9 as the minimum version (#26)

    ### Motivation
    
    Part of addressing
    apple/swift-openapi-generator#75 and
    apple/swift-openapi-generator#119.
    
    ### Modifications
    
    Bumped Swift tools version to 5.9 and made the `ExistentialAny` build
    setting unconditional.
    
    ### Result
    
    Building the package requires 5.9 now.
    
    ### Test Plan
    
    Ran tests, all passed when using a Swift 5.9 toolchain.
    czechboy0 authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    8c6cc59 View commit details
    Browse the repository at this point in the history
  3. Remove #if swift(>=5.9) check in Package.swift (#27)

    ### Motivation
    
    In #26 we bumped the minimum tools version to Swift 5.9, but we left the
    `#if swift(>5.9)` compiler directive when enabling existential any by
    default.
    
    ### Modifications
    
    Remove #if swift(>=5.9) check in Package.swift
    
    ### Result
    
    No checking for Swift 5.9+, because that's now the default.
    
    ### Test Plan
    
    CI.
    simonjbeaumont authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e0c24bc View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Bump to 1.0.0-alpha.1 (#28)

    Bump to 1.0.0-alpha.1
    
    ### Motivation
    
    Prepare for 1.0.0-alpha.1.
    
    ### Modifications
    
    - Updated runtime dependency.
    - Updated docs.
    
    ### Result
    
    Ready to tag 1.0.0-alpha.1.
    
    ### Test Plan
    
    All tests pass.
    
    
    Reviewed by: simonjbeaumont
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #28
    czechboy0 authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f5bf294 View commit details
    Browse the repository at this point in the history
  2. Handle large payloads on 32bit platforms gracefully (#29)

    Handle large payloads on 32bit platforms gracefully
    
    ### Motivation
    
    If there's a request payload with a number of bytes that can't fit into 32 bits, we'd crash.
    
    ### Modifications
    
    Use a graceful initializer and use `.unknown` (so no `content-length` will be sent) if the size exceeds the max of a 32bit int.
    
    ### Result
    
    No crash for large payloads on 32bit platforms.
    
    ### Test Plan
    
    Tests pass.
    
    
    Reviewed by: dnadoba
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #29
    czechboy0 authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0859ead View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Add visionOS platform support (#31)

    ### Motivation
    
    While this isn't technically necessary, as all versions of a platform
    not explicitly mentioned are assumed to be supported, it's better to be
    explicit here.
    
    ### Modifications
    
    Add `visionOS(.v1)` to the list of supported platforms.
    
    ### Result
    
    Clearer support matrix.
    
    ### Test Plan
    
    N/A, this is basically just a documentation change.
    czechboy0 authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1ab51fe View commit details
    Browse the repository at this point in the history
  2. Default the configuration parameter (#32)

    Default the configuration parameter
    
    ### Motivation
    
    The AsyncHTTPClient transport API has undergone changes in recent months and we didn't bring back the default initializer after we adopted the shared EventLoopGroup, allowing you to create a transport with just `let transport = AsyncHTTPClientTransport()`.
    
    ### Modifications
    
    Default the configuration parameter in the initializer to be able to do that. It's already documented to work, but it doesn't.
    
    ### Result
    
    Match the documented behavior of being able to use `let transport = AsyncHTTPClientTransport()`.
    
    ### Test Plan
    
    Tests still pass.
    
    
    Reviewed by: dnadoba
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #32
    czechboy0 authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    7edc421 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddc356e View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Explicit dependency on HTTPTypes (#34)

    ### Motivation
    
    Recent SwiftPM versions seem to be a bit stricter about using (i.e.,
    `import ...`) transitive dependencies without explicitly declaring them
    as direct dependencies.
    
    ### Modifications
    
    Explicitly depend on the HTTPTypes module from swift-http-types.
    
    ### Result
    
    More explicitly declare the dependency graph.
    
    ### Test Plan
    
    All tests pass.
    czechboy0 authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    410d691 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Add issue template, redirecting to swift-openapi-generator issues (#36)

    ### Motivation
    
    We centralize the issues for all the repos in the Swift OpenAPI
    Generator project in the generator repo. Using an issue template will
    make this even clearer, because it will allow people to use the normal
    Github workflow to discover the process and provide a link to where to
    file their issue.
    
    ### Modifications
    
    Add issue template, redirecting to swift-openapi-generator issues.
    
    ### Result
    
    When people try and file an issue, they'll be presented with a button
    that takes them to the generator repo issues page.
    
    ### Test Plan
    
    Manual.
    simonjbeaumont authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    bdb9c8f View commit details
    Browse the repository at this point in the history
  2. Prep 1.0 (#37)

    ### Motivation
    
    Prep 1.0 - docs.
    
    ### Modifications
    
    See above.
    
    ### Result
    
    Updated for 1.0.
    
    ### Test Plan
    
    Previewed locally.
    czechboy0 authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    abfe558 View commit details
    Browse the repository at this point in the history
Loading