Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.4
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.5
Choose a head ref
  • 18 commits
  • 8 files changed
  • 6 contributors

Commits on Oct 29, 2019

  1. Configuration menu
    Copy the full SHA
    898b6d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2020

  1. bug #34114 [Console] SymonfyStyle - Check value isset to avoid PHP no…

    …tice (leevigraham)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Console] SymonfyStyle - Check value isset to avoid PHP notice
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #34093
    | License       | MIT
    | Doc PR        | n/a
    
    This PR addresses the issue when a default value is not a valid choice. Currently this would throw a notice which outputs to the console.
    
    This fix is a similar implementation to the `QuestionHelper`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Console/Helper/QuestionHelper.php#L63
    
    Example console command and output can be found in the issue: #34093
    
    Commits
    -------
    
    c9072c70ef Check value isset to avoid PHP notice
    fabpot committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    f25d38d View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.4

    * 3.4:
      [Phpunit] Fix running skipped tests expecting only deprecations
      [DependencyInjection] #35505 Fix typo in test name
      [Yaml][Inline] Fail properly on empty object tag and empty const tag
      Check non-null type for numeric type
      Check value isset to avoid PHP notice
      bug symfony#28179 [DomCrawler] Skip disabled fields processing in Form
    nicolas-grekas committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    a090600 View commit details
    Browse the repository at this point in the history
  3. Merge branch '4.4' into 5.0

    * 4.4:
      [Phpunit] Fix running skipped tests expecting only deprecations
      Fix merge
      [Config] dont catch instances of Error
      [HttpClient] fix HttpClientDataCollector when handling canceled responses
      [DependencyInjection] #35505 Fix typo in test name
      [Yaml][Inline] Fail properly on empty object tag and empty const tag
      Check non-null type for numeric type
      Check value isset to avoid PHP notice
      bug symfony#28179 [DomCrawler] Skip disabled fields processing in Form
    chalasr committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    b655db2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Fix CS

    fabpot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    6e3cf40 View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.4

    * 3.4:
      Fix CS
    fabpot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    1a8d20d View commit details
    Browse the repository at this point in the history
  3. Fix CS

    fabpot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    54e1cf9 View commit details
    Browse the repository at this point in the history
  4. Merge branch '4.4' into 5.0

    * 4.4:
      Fix CS
      Fix CS
    fabpot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    1ba9fef View commit details
    Browse the repository at this point in the history
  5. Fix CS

    fabpot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    d4d34ad View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. 4 Configuration menu
    Copy the full SHA
    55b6ebf View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.4' into 5.0

    * 4.4:
      [FrameworkBundle] fix "samesite" in XSD
      [Console] Consider STDIN interactive
      Update UserPasswordEncoderCommand.php
      [HttpFoundation][FrameworkBundle] fix support for samesite in session cookies
      [DoctrineBridge] Fixed submitting ids with query limit or offset
    nicolas-grekas committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    515c7ee View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Configuration menu
    Copy the full SHA
    5afdac5 View commit details
    Browse the repository at this point in the history
  2. [Console] Handle zero row count in appendRow() for Table

    Adam Prickett authored and fabpot committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    a65caf4 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Merge branch '3.4' into 4.4

    * 3.4:
      fix unix root dir issue
      sync validator translation files with master
      fix anchor
      fix links to releases page (formerly known as "roadmap")
      [Console] Don't load same-namespace alternatives on exact match found
    fabpot committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    db75aa0 View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.4' into 5.0

    * 4.4:
      fix unix root dir issue
      sync validator translation files with master
      [HttpFoundation] fix not sending Content-Type header for 204 responses
      [ErrorHandler] silence warning when zend.assertions=-1
      fix anchor
      [Console] Handle zero row count in appendRow() for Table
      fix links to releases page (formerly known as "roadmap")
      [Console] Don't load same-namespace alternatives on exact match found
    fabpot committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    9c05b51 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Configuration menu
    Copy the full SHA
    6827023 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Merge branch '3.4' into 4.4

    * 3.4:
      [ExpressionLanguage] Fixed collisions of character operators with object properties
      [Validator] Remove specific check for Valid targets
      [PhpUnitBridge] Use trait instead of extending deprecated class
      fix remember me
      Use strict assertion in asset tests
      [DoctrineBridge][DoctrineExtractor] Fix indexBy with custom and some core types
      Do not rely on the current locale when dumping a Graphviz object
      fix typo
      [Ldap] force default network timeout
      [Config] don't throw on missing excluded paths
      Docs: Typo, grammar
      [Validator] Add the missing translations for the Polish ("pl") locale
      [Console] Inline exact-match handling with 4.4
      Set previous exception when rethrown from controller resolver
      [VarDumper] fixed DateCaster not displaying additional fields
      [HttpKernel] fix registering DebugHandlersListener regardless of the PHP_SAPI
    fabpot committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    4fa15ae View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.4' into 5.0

    * 4.4: (25 commits)
      [DoctrineBridge] Use new Types::* constants and support new json type
      [Debug][ErrorHandler] improved deprecation notices for methods new args and return type
      [BrowserKit] Nested file array prevents uploading file
      [ExpressionLanguage] Fixed collisions of character operators with object properties
      [Validator] Remove specific check for Valid targets
      [PhpUnitBridge] Use trait instead of extending deprecated class
      Fix versioned namespace clears
      fix remember me
      Use strict assertion in asset tests
      [DoctrineBridge][DoctrineExtractor] Fix indexBy with custom and some core types
      Do not rely on the current locale when dumping a Graphviz object
      fix typo
      [Ldap] force default network timeout
      [Config] don't throw on missing excluded paths
      Docs: Typo, grammar
      [Validator] Add the missing translations for the Polish ("pl") locale
      [PhpUnitBridge] Add compatibility to PHPUnit 9 #35662
      [Routing] Add locale requirement for localized routes
      [Console] Inline exact-match handling with 4.4
      Set previous exception when rethrown from controller resolver
      ...
    nicolas-grekas committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    d29e2d3 View commit details
    Browse the repository at this point in the history
Loading